Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINTAINERS.md: add collaborators and organization members #2308

Merged
merged 7 commits into from
Sep 12, 2018

Conversation

sbrl
Copy link
Member

@sbrl sbrl commented Sep 7, 2018

Part of #2266.

@sbrl sbrl added the community Issues/PRs dealing with role changes and community organization. label Sep 7, 2018
Copy link
Member

@waldyrious waldyrious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this :) I left some inline comments.

MAINTAINERS.md Outdated
@@ -1,6 +1,22 @@
# Maintainers
This file contains a list of the maintainers of tldr-pages.


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why two blank lines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it's just habit I think. When I write markdown elsewhere I use a double blank line to delimit sections.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but in that case please apply that pattern consistently throughout the file. I'd suggest two blank lines above section headings, and one below.

MAINTAINERS.md Outdated

## Current collaborators
The following people are collaborators on this repository, enabling them to label and close issues,
and review and merge pull requests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add the link to the automated list: https://github.com/tldr-pages/tldr/settings/collaboration

MAINTAINERS.md Outdated


## Current members
These people are members of the tldr-pages organization.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAINTAINERS.md Show resolved Hide resolved
MAINTAINERS.md Outdated
@@ -1,6 +1,22 @@
# Maintainers
This file contains a list of the maintainers of tldr-pages.


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but in that case please apply that pattern consistently throughout the file. I'd suggest two blank lines above section headings, and one below.

MAINTAINERS.md Outdated


## Current members
These people are members of the tldr-pages organization. An automated list can
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also mention what they can/should do, similarly to what you wrote in the previous section. Let me know if this information is not clear.

@sbrl
Copy link
Member Author

sbrl commented Sep 10, 2018

Ah, oops! I missed a bit, didn't I? Thanks for spotting that :P

@waldyrious
Copy link
Member

@sbrl are you planning to address this comment as well? Let me know if I can help.

@sbrl
Copy link
Member Author

sbrl commented Sep 11, 2018

Ah, oops! I think it must have slipped through the net. Thanks for the reminder, @waldyrious :D

MAINTAINERS.md Outdated
@@ -16,7 +16,9 @@ can be found [here](https://github.com/tldr-pages/tldr/settings/collaboration).

## Current members

These people are members of the tldr-pages organization. An automated list can
These people are members of the tldr-pages organization. As well as doing
everything that a contributor can do, a member also has access to all the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps "a member also has write access", to make this clearer? Anyone can "access" (i.e. read) the repos :)

Copy link
Member

@waldyrious waldyrious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again for taking this on!

@agnivade agnivade merged commit b88cea9 into master Sep 12, 2018
@agnivade agnivade deleted the edit-maintainers branch September 12, 2018 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues/PRs dealing with role changes and community organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants