Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINTAINERS.md: add collaborators and organization members #2308

Merged
merged 7 commits into from
Sep 12, 2018
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions MAINTAINERS.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,22 @@
# Maintainers
This file contains a list of the maintainers of tldr-pages.


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why two blank lines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it's just habit I think. When I write markdown elsewhere I use a double blank line to delimit sections.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but in that case please apply that pattern consistently throughout the file. I'd suggest two blank lines above section headings, and one below.

## Current collaborators
The following people are collaborators on this repository, enabling them to label and close issues,
and review and merge pull requests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add the link to the automated list: https://github.com/tldr-pages/tldr/settings/collaboration


- Max Xu ([@jsonbruce](https://github.com/jsonbruce))
- Jeef ([@jeeftor](https://github.com/jeeftor))
- Muhammad Falak R Wani ([@mfrw](https://github.com/mfrw))


## Current members
These people are members of the tldr-pages organization.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


- Owen Voke ([@pxgamer](https://github.com/pxgamer))


## Current owners

The following people are the current owners of the tldr-pages organization,
sbrl marked this conversation as resolved.
Show resolved Hide resolved
Expand Down