Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fdroidcl: add page #3541

Merged
merged 2 commits into from
Nov 11, 2019
Merged

fdroidcl: add page #3541

merged 2 commits into from
Nov 11, 2019

Conversation

Rudloff
Copy link
Collaborator

@Rudloff Rudloff commented Nov 9, 2019

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@CLAassistant
Copy link

CLAassistant commented Nov 9, 2019

CLA assistant check
All committers have signed the CLA.

@sbrl
Copy link
Member

sbrl commented Nov 9, 2019

Hey, @Rudloff! Thanks for the new page. Perhaps you could sign the CLA please? Then we can get to reviewing.

Note that the email address you committed with has to be associated with your GitHub account for it to register.

@einverne einverne added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Nov 10, 2019
Copy link
Member

@mebeim mebeim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the page @Rudloff 🙂

@mebeim mebeim merged commit 6b4c61b into tldr-pages:master Nov 11, 2019
@agnivade
Copy link
Member

@mvdan - Any comments on this ? 😃 Would you like something changed ?

@mvdan
Copy link

mvdan commented Nov 12, 2019

I guess I'd also show search to find apps, and install to actually install them on a device. But yeah, LGTM :)

@agnivade
Copy link
Member

@Rudloff, since we have space for more, would you like to make those changes ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants