Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fdroidcl: add search and install examples #3561

Merged
merged 3 commits into from
Nov 14, 2019
Merged

fdroidcl: add search and install examples #3561

merged 3 commits into from
Nov 14, 2019

Conversation

Rudloff
Copy link
Collaborator

@Rudloff Rudloff commented Nov 12, 2019

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

See #3541 (comment).

sbrl
sbrl reviewed Nov 12, 2019
View reviewed changes
pages/common/fdroidcl.md Outdated Show resolved Hide resolved
@Rudloff @sbrl
Update pages/common/fdroidcl.md
eb0df02 
Co-Authored-By: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
einverne
einverne approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@einverne einverne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@einverne einverne added the page edit Changes to an existing page(s). label Nov 13, 2019
agnivade
agnivade requested changes Nov 13, 2019
View reviewed changes
pages/common/fdroidcl.md Outdated Show resolved Hide resolved
schneiderl
schneiderl reviewed Nov 13, 2019
View reviewed changes
Copy link
Collaborator

@schneiderl schneiderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@einverne einverne merged commit ce3c466 into tldr-pages:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schneiderl schneiderl schneiderl left review comments

@sbrl sbrl sbrl left review comments

@einverne einverne einverne approved these changes

@agnivade agnivade agnivade approved these changes

@andrik andrik andrik approved these changes

Assignees
No one assigned
Labels
page edit Changes to an existing page(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rudloff @andrik @agnivade @einverne @sbrl @schneiderl