-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deluser, userdel: add page #5245
Conversation
Hello! I've noticed something unusual when checking this PR:
Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits. |
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @TheLastGimbus, and thank you for the new page! I've left some comments below for you to review.
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@TheLastGimbus I think
Well, they're very old 😄 #175 is very old considering that this is PR #5245! @TheLastGimbus Will you please:
Sorry, I know that's a lot, but these are old pages and need a little cleanup. Thank you! Note: if you're committing locally, remember to run |
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Note to maintainers: the deleted |
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Okay, everything resolved and cleaned up as you wished
...but I do agree with that very much. Better finish it once for good than fix it 3 more times later 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @TheLastGimbus, I think we can add 2 extra examples.
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
common/
,linux/
, etc.)Hi there!
Current
deluser
is in thepages/common/
, which I don't understand, because it works a little bit different on different OSes 🤔I added the correct version to
pages/linux/
, but dunno whether I should also delete old one incommon
I know you guys are picky about language, so 1-2 example might need re-phrasing 😅