Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deluser, userdel: add page #5245

Merged
merged 14 commits into from
Feb 7, 2021
Merged

Conversation

TheLastGimbus
Copy link
Contributor

@TheLastGimbus TheLastGimbus commented Feb 6, 2021

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Hi there!

Current deluser is in the pages/common/, which I don't understand, because it works a little bit different on different OSes 🤔

I added the correct version to pages/linux/, but dunno whether I should also delete old one in common

I know you guys are picky about language, so 1-2 example might need re-phrasing 😅

@tldr-bot
Copy link

tldr-bot commented Feb 6, 2021

Hello! I've noticed something unusual when checking this PR:

  • The page linux/deluser.md already exists under the common platform.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@tldr-bot
Copy link

tldr-bot commented Feb 6, 2021

The build for this PR failed with the following error(s):

pages/linux/deluser.md:3: TLDR004 Command descriptions should end in a period
pages/linux/deluser.md:4: TLDR004 Command descriptions should end in a period
pages/linux/deluser.md:19: TLDR103 Command example is missing its closing backtick

Please fix the error(s) and push again.

@bl-ue bl-ue added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Feb 6, 2021
@bl-ue bl-ue changed the title deluser: Add linux page deluser: add page Feb 6, 2021
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @TheLastGimbus, and thank you for the new page! I've left some comments below for you to review.

TheLastGimbus and others added 6 commits February 6, 2021 14:39
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@bl-ue
Copy link
Contributor

bl-ue commented Feb 6, 2021

@TheLastGimbus I think common/deluser.md might actually be userdel (#175) which I believe is more low-level.

deluser.md and userdel.md should be in linux/ not common/ 🤔

Well, they're very old 😄 #175 is very old considering that this is PR #5245!

@TheLastGimbus Will you please:

  1. Delete common/userdel.md
  2. Rename common/deluser.md to linux/userdel.md
  3. Add https://man7.org/linux/man-pages/man8/userdel.8.html as a "More information" link to linux/userdel.md

Sorry, I know that's a lot, but these are old pages and need a little cleanup.

Thank you!

Note: if you're committing locally, remember to run git pull to incorporate the changes made on GitHub into your local repo!

TheLastGimbus and others added 2 commits February 6, 2021 15:42
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@bl-ue
Copy link
Contributor

bl-ue commented Feb 6, 2021

Note to maintainers: the deleted deluser pages was wrong, it shouldn't have been added. @rubenvereecken added it #175, but I think they confused it with userdel.

Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@TheLastGimbus
Copy link
Contributor Author

Okay, everything resolved and cleaned up as you wished

I know you guys are picky about language

...but I do agree with that very much. Better finish it once for good than fix it 3 more times later 👍

Copy link
Collaborator

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TheLastGimbus, I think we can add 2 extra examples.

@navarroaxel navarroaxel changed the title deluser: add page deluser, userdel: add page Feb 6, 2021
TheLastGimbus and others added 3 commits February 6, 2021 20:47
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@bl-ue bl-ue requested a review from sbrl February 7, 2021 00:53
@navarroaxel navarroaxel merged commit 7dcdcea into tldr-pages:master Feb 7, 2021
@TheLastGimbus TheLastGimbus deleted the fix_deluser branch February 7, 2021 19:32
bl-ue added a commit that referenced this pull request Mar 6, 2021
bl-ue added a commit that referenced this pull request Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants