Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deluser: sync translations with PR #5245 #5355

Merged
merged 1 commit into from
Mar 8, 2021
Merged

deluser: sync translations with PR #5245 #5355

merged 1 commit into from
Mar 8, 2021

Conversation

bl-ue
Copy link
Contributor

@bl-ue bl-ue commented Mar 6, 2021

Syncs the Italian and Korean translations of common/deluser.md with the English translation, see PR #5245.

cc @TheLastGimbus

@bl-ue bl-ue added the translation Issues requesting translating pages from English to other languages. label Mar 6, 2021
sbrl
sbrl reviewed Mar 6, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ummm all I see are 2 deleted files? If the translations are updated, then there's really no need to delete these. In fact, the translations dashboard should mark them ass outdated if the number of examples are different.

@bl-ue
Copy link
Contributor Author

bl-ue commented Mar 6, 2021

Yeah, common/deluser.md was moved to linux/deluser.md, but it had examples added. I thought the best way to settle the situation was to just delete them, then if somebody tried to view the page in their language they'd see a not found and maybe submit a translation, rather than see an outdated page but think it's up to date, etc.. But instead I'll restore them, move them to linux/, and add what I can: the more information link 😊

sbrl
sbrl requested changes Mar 6, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to prevent accidental merge until @bl-ue applies changes.

@navarroaxel navarroaxel self-requested a review March 6, 2021 21:05
@bl-ue bl-ue force-pushed the bl-ue/synci18n-deluser branch from 43b2399 to 9b3d4e2 Compare March 6, 2021 21:08
@bl-ue bl-ue requested a review from sbrl March 6, 2021 21:08
sbrl
sbrl approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bl-ue!

@bl-ue bl-ue merged commit c81f9c7 into master Mar 8, 2021
@sbrl sbrl deleted the bl-ue/synci18n-deluser branch March 8, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@sbrl sbrl sbrl approved these changes

Assignees
No one assigned
Labels
translation Issues requesting translating pages from English to other languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bl-ue @navarroaxel @sbrl