Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings: add more information link #5530

Merged
merged 1 commit into from
Mar 31, 2021
Merged

settings: add more information link #5530

merged 1 commit into from
Mar 31, 2021

Conversation

marchersimon
Copy link
Collaborator

For #5510
The hash in the url is unfortunate, but I couldn't find anything else, which is slightly related.

@marchersimon marchersimon added the page edit Changes to an existing page(s). label Mar 29, 2021
@marchersimon marchersimon mentioned this pull request Mar 29, 2021
Closed
@marchersimon marchersimon changed the title settings: add link settings: add more information link Mar 29, 2021
bl-ue
bl-ue approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt the hash will change.

@tansiret tansiret requested a review from Rudloff March 30, 2021 08:58
sbrl
sbrl approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm yeah, this seems like the nest we can find. It's certainly far from perfect (it prefixes with adb shell for one), but it seems like there's no better documentation available. Let's use this then.

@navarroaxel navarroaxel merged commit b02c9f5 into tldr-pages:master Mar 31, 2021
@marchersimon marchersimon deleted the settings-link branch March 31, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bl-ue bl-ue bl-ue approved these changes

@sbrl sbrl sbrl approved these changes

@navarroaxel navarroaxel navarroaxel approved these changes

@Rudloff Rudloff Awaiting requested review from Rudloff

Assignees
No one assigned
Labels
page edit Changes to an existing page(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marchersimon @navarroaxel @sbrl @bl-ue