Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Add links to all existing pages #5510

Closed
waldyrious opened this issue Mar 26, 2021 · 46 comments
Closed

Epic: Add links to all existing pages #5510

waldyrious opened this issue Mar 26, 2021 · 46 comments
Labels
help wanted You can help make tldr-pages better! mass changes Changes that affect multiple pages. syntax Issues related to the content and markup of the pages.

Comments

@waldyrious
Copy link
Member

waldyrious commented Mar 26, 2021

Since #2649, tldr pages support adding a link to the tool's homepage, and substantial efforts to backfill links into existing pages have been made, but many are still lacking it.

We should ensure that all pages have a link that people can follow to learn more about the tool and explore more comprehensive documentation. Pages of projects that don't have a dedicated web page should either link to their parent project's page, or we should come up with a way to explicitly indicate that they don't have a homepage.

(Note: This should be done with a separate PR for each page (or at best, multi-page PRs for related sets of pages, such as all the subcommands of a given command), so that discussion about which links to use for some pages won't block the straightforward changes to the other pages.)

Once that work is completed, we should add a check to tldr-lint to make this field required, thus ensuring that new pages won't regress our coverage in that regard (see #5046 for examples of link-related checks that were incorporated into tldr-lint). We should also change the template for a page in CONTRIBUTING.md, the style guide, and other places where that may be relevant.

@waldyrious waldyrious added syntax Issues related to the content and markup of the pages. help wanted You can help make tldr-pages better! labels Mar 26, 2021
@navarroaxel
Copy link
Collaborator

Question: What we should do with pages like https://github.com/tldr-pages/tldr/blob/master/pages/linux/ksvgtopng5.md? This is an internal command/util from the KDE Plasma desktop and doesn't have a man page. Should we use the link to the git repository?

@bl-ue
Copy link
Contributor

bl-ue commented Mar 26, 2021

I'd say the Git repository for that tool (or group of related tools), or the parent project's page (e.g. the KDE Plasma Desktop's page). We link to Git repos (e.g. GitHub, GitLab) a lot.

@marchersimon
Copy link
Collaborator

marchersimon commented Mar 29, 2021

An updated version of the list was moved to #6062, since it was rather long.

The old list:

GNU coreutils

(#5510 (comment))

en More information:
bs Više informacija:
da Mere information:
de Mehr Informationen:
es Más información:
fa اطلاعات بیشتر:
fr see footnote
hbs Više informacija:
hi अधिक जानकारी:
id Informasi lebih lanjut:
it Maggiori informazioni:
ja 詳しくはこちら:
ko 더 많은 정보:
ml കൂടുതൽ വിവരങ്ങൾ:
nl Meer informatie:
no Mer informasjon:
pl Więcej informacji:
pt_BR Mais informações:
pt_PT Mais informações:
ru Больше информации:
sv Mer information:
ta மேலும் தகவல்:
th ดูเพิ่มเติม:
tr Daha fazla bilgi için:
zh 更多信息:
zh_TW 更多資訊:

* The French translation cantains a thin unbreaking space, which can't be copied from the Github UI. The easiest way would be to copy it from another French page, like common/tar.md (#5510 (comment))

@marchersimon
Copy link
Collaborator

I'm not sure if this was a good idea though...

@bl-ue
Copy link
Contributor

bl-ue commented Mar 29, 2021

Yeah, that's a crazily long list 😂

@marchersimon I'd open PRs fixing pages in batches of 10 or so, to reduce the PR count given these are simple changes.

@marchersimon
Copy link
Collaborator

@bl-ue what about @waldyrious's suggestion?

(Note: This should be done with a separate PR for each page (or at best, multi-page PRs for related sets of pages, such as all the subcommands of a given command), so that discussion about which links to use for some pages won't block the straightforward changes to the other pages.)

@bl-ue
Copy link
Contributor

bl-ue commented Mar 29, 2021

I'm fine with that, the only thing I'm not sure about of is opening a bunch of PRs that each add one line to one file...I'm not sure if that's a great idea. But if that's okay with @waldyrious it's okay with me.

@waldyrious
Copy link
Member Author

waldyrious commented Mar 29, 2021

If multiple PRs are adding links to the same site, or add links to pages that are related to each other, then yeah, it makes more sense to group those changes into a single PR.

Other than that, I don't see any problems with having lots of small PRs that are indeed unrelated to each other. Simple PRs are easy to review, and allow a fast turnaround, which is good both for maintainers and contributors alike.

@tomadojuice
Copy link
Contributor

tomadojuice commented Mar 29, 2021

For the GNU coreutils (cd, mv, ...) should we add the link to the respective page on gnu.org? Example https://www.gnu.org/software/coreutils/manual/html_node/mv-invocation.html for mv. I don't really see another way...

@bl-ue
Copy link
Contributor

bl-ue commented Mar 29, 2021

Yes definitely. Those pages are very informative.

@marchersimon
Copy link
Collaborator

marchersimon commented Mar 29, 2021

Should we also change the links of the current coreutils? (chmod, dd, mkdir, touch, b2sum, cat, basename)

@tomadojuice
Copy link
Contributor

@marchersimon It's certainly helpful but then again you could just look it up in the man page.

@bl-ue
Copy link
Contributor

bl-ue commented Mar 29, 2021

If they're man7.org ones I think we should move them to the gnu pages. I like those ones better; they're official and informative (and a contrast to man7.org that's all over lots of pages)

@sbrl
Copy link
Member

sbrl commented Apr 3, 2021

Yeah, finding a way to explicitly indicate that there isn't a suitable web page is a good idea. We can't use the angle-brackets (<N/A>) though, because in the CommonMark spec that's the syntax for autolinks. Perhaps simply dropping the angle brackets and doing something like this would be better:

> More information: N/A.

@bl-ue
Copy link
Contributor

bl-ue commented Apr 8, 2021

What about alias pages #5299? Should we add links to them?

In that issue I wrote

with the link intentionally omitted.

But now I'm not sure that's necessary.

@marchersimon
Copy link
Collaborator

If we didn't, that would cause problems with tldr-lint as soon as we make them required. But we also can't use <N/A>, since that would be wrong.

@waldyrious
Copy link
Member Author

I'd say we can adjust the logic of the linter to

  1. ensure all alias pages follow the same format (like we do with the link labels, ensuring it spells exactly "More information:", etc.), and then
  2. implement the upcoming rule that checks that a link (or N/A) is present in a way that ignores the alias pages (which should be easily identifiable if the point above is implemented).

@bl-ue
Copy link
Contributor

bl-ue commented Apr 9, 2021

👍🏻. What if an alias has it's own particular page which documents the fact that it is an alias and links to the source command's page?

I'm inclined to require links on all alias pages, and ensure they are identical to those of the source pages.

@waldyrious
Copy link
Member Author

I don't understand what you mean. Are you suggesting to use the "More information" field in alias pages to link to the original pages, rather than the example format that was proposed in #5299?

@bl-ue
Copy link
Contributor

bl-ue commented Apr 9, 2021

Sorry, that wasn't very coherent 😛

No, I was that an alias page should (must) have the exact same link as the source page. For example, if abc.md has a link to https://abc.com/, then def.md, which is an alias page to abc.md, should have a link https://abc.com/.

@waldyrious
Copy link
Member Author

That seems redundant and even noisy IMO. The alias page should be as short as possible and contain only the information needed to allow the user to find the correct page. In fact, I'm even thinking that we might want to use a more compact format, such as

# foo

> Alias of `bar`.

(though this format is something to be discussed at #5299, not here).

@bl-ue
Copy link
Contributor

bl-ue commented Apr 9, 2021

About the link: I agree.
About the compact format: so zero examples? I'm not sure the linter would like that.

@waldyrious
Copy link
Member Author

If the linter will have an exception for alias pages so it won't require a link in those cases, then it can just as well do the same for requiring examples.

@patricedenis
Copy link
Collaborator

patricedenis commented May 12, 2021

Hi
I was trying to add pinky.md but then I found that it was already included from Pull Request #2284 and commit #e4c03937386.
We may tick the case above, don't we?

Oh no, I nevermind this issue is to add links.
I'll do it right now ^^

@marchersimon
Copy link
Collaborator

Should I move my list to a seperate issue, so it's possible to scroll and discuss here and keep track of pages in the new issue?

@sbrl
Copy link
Member

sbrl commented May 27, 2021

@marchersimon perhaps a good idea, since it is quite long haha

Have this as the meta discussion issue, and a new one as a tracking issue.

@marchersimon
Copy link
Collaborator

marchersimon commented May 28, 2021

Done. I left out finished pages to avoid getting a notification for every PR which was linked in the list.

@marchersimon
Copy link
Collaborator

Should I also close this issue or is there something left to discuss?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted You can help make tldr-pages better! mass changes Changes that affect multiple pages. syntax Issues related to the content and markup of the pages.
Projects
None yet
Development

No branches or pull requests

8 participants