Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm: add more information link #5552

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Conversation

marchersimon
Copy link
Collaborator

For #5510

@marchersimon marchersimon added page edit Changes to an existing page(s). translation Translate pages from one language to another. labels Mar 29, 2021
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did my tool work? 🙂

@marchersimon
Copy link
Collaborator Author

marchersimon commented Mar 29, 2021

@bl-ue absolutely, I love it. Would be cool if it would automatically perform a git add.

@bl-ue
Copy link
Contributor

bl-ue commented Mar 29, 2021

I thought of that. Would it be convenient for it to commit as well?

@marchersimon
Copy link
Collaborator Author

I don't think so. When I do it myself I can check if I'm on the right branch and write my own commit message. Also, I have to commit only once.

@bl-ue
Copy link
Contributor

bl-ue commented Mar 29, 2021

You can also use git add .—are you aware of that? 🤔

@marchersimon
Copy link
Collaborator Author

I have many untracked files (like scripts or todolists) and to make sure I don't add anything by mistake I try to avoid this.

@bl-ue
Copy link
Contributor

bl-ue commented Mar 29, 2021

Gotcha. Will do.

@bl-ue
Copy link
Contributor

bl-ue commented Mar 29, 2021

Sorry for the delay, done. 🎉

Add -s to auto stage modified pages.

@tansiret tansiret self-requested a review March 30, 2021 07:15
Copy link
Member

@tansiret tansiret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tansiret tansiret merged commit 6266832 into tldr-pages:master Mar 30, 2021
@marchersimon marchersimon deleted the rm-link branch March 30, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s). translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants