Merge pull request #306 from chcharcharlie/rangeend

Fix range end checks, range end can be the same with data length because the end bracket is open
tlsnotary · Aug 23, 2023 · ec364ce · ec364ce
2 parents aaea854 + b814608
commit ec364ce
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/tlsn/tlsn-core/src/substrings/proof.rs b/tlsn/tlsn-core/src/substrings/proof.rs
@@ -68,14 +68,14 @@ impl SubstringsProof {
         for comm in self.inclusion_proof.commitments().iter() {
             if comm.direction() == &Direction::Sent {
                 for r in comm.ranges() {
-                    if r.end >= header.sent_len() {
+                    if r.end > header.sent_len() {
                         return Err(Error::ValidationError);
                     }
                 }
             } else {
                 // comm.direction() == &Direction::Received
                 for r in comm.ranges() {
-                    if r.end >= header.recv_len() {
+                    if r.end > header.recv_len() {
                         return Err(Error::ValidationError);
                     }
                 }

diff --git a/tlsn/tlsn-core/src/transcript.rs b/tlsn/tlsn-core/src/transcript.rs
@@ -44,7 +44,7 @@ impl Transcript {
 
         let mut dst: Vec<u8> = Vec::new();
         for r in ranges {
-            if r.end as usize >= self.data.len() {
+            if r.end as usize > self.data.len() {
                 // range bounds must be within `src` length
                 return Err(Error::InternalError);
             } else {