Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix range end checks, range end can be the same with data length because the end bracket is open #306

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Fix range end checks, range end can be the same with data length because the end bracket is open #306

merged 1 commit into from
Aug 23, 2023

Conversation

chcharcharlie
Copy link
Contributor

No description provided.

@chcharcharlie
Copy link
Contributor Author

Should be straightforward but can provide more info if needed.

Found this when testing generating a notarized session and substring proofs, also when validating substring proofs of the entire received data.

@sinui0
Copy link
Member

sinui0 commented Aug 23, 2023

Thank you for the PR 🙏

It looks like @themighty1 also caught this in #304 https://github.com/tlsnotary/tlsn/pull/304/files#diff-97d982f0d8492e2379411ec1434e954c8a27fc87f845accc46afae056f04de26

@sinui0 sinui0 requested a review from themighty1 August 23, 2023 05:54
themighty1
themighty1 approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@themighty1 themighty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for the PR

@themighty1 themighty1 merged commit ec364ce into tlsnotary:dev Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themighty1 themighty1 themighty1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chcharcharlie @sinui0 @themighty1