Add simple prover and simple verifier examples. #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themighty1
commented
Aug 21, 2023
yuroitaki
approved these changes
Aug 21, 2023
heeckhau
approved these changes
Aug 22, 2023
heeckhau
reviewed
Aug 22, 2023
It looks nice, but I am afraid that this could complicate things, since these are non-ASCII characters and probably longer than one byte in UTF-8? |
|
|
|
@heeckhau, I tried printing a square which is extended ASCII 219 but rust prints � which is a character of length > 1 byte. If a developer tries to copy-paste the console output and parse it elsewhere, he may encounter issues. for the purposes of the upcoming hackathon, it is safer to stick with 7-bit ascii to avoid surprises. |
themighty1
force-pushed
the
simple_examples
branch
from
a89c926
to
8f33d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds simple prover and simple verifier examples which will be run by those following a quick start guide tlsnotary/docs-mdbook#25
Most of the
simple_prover.rscode was copied fromtwitter_dm.rsexample.Also fixes a bug in
tlsn-corewhich prevented the example from running (so I included the fix in this PR)