-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: intel sgx attestation #630
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #630 +/- ##
==========================================
- Coverage 54.55% 54.53% -0.03%
==========================================
Files 192 193 +1
Lines 20518 20599 +81
==========================================
+ Hits 11194 11233 +39
- Misses 9324 9366 +42 ☔ View full report in Codecov by Sentry. |
Co-authored-by: yuroitaki <25913766+yuroitaki@users.noreply.github.com>
Co-authored-by: yuroitaki <25913766+yuroitaki@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👯♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm modulo a couple nits
} | ||
} | ||
|
||
static PUBLIC_KEY: OnceCell<PublicKey> = OnceCell::new(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sinui0 i wanted to make it explicit that the key can only be set once. so if someone figured out a way to exec the calling function again it couldnt be reset. not sure if thats possible or even if oncecell is the right way to do it
f539688
to
8930529
Compare
sgx signed quote with notary-server pub key used as report-data