Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: intel sgx attestation #630
feat: intel sgx attestation #630
Changes from 5 commits
93bfd1a
387d52a
8b288ec
5476770
a2a976d
4e0afaa
0c9767a
8930529
c03449d
2a4f0a3
c5c72f0
66f5c86
de6d25e
3d92843
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 156 in crates/notary/server/src/server.rs
Codecov / codecov/patch
crates/notary/server/src/server.rs#L155-L156
Check warning on line 21 in crates/notary/server/src/tee.rs
Codecov / codecov/patch
crates/notary/server/src/tee.rs#L21
Check warning on line 38 in crates/notary/server/src/tee.rs
Codecov / codecov/patch
crates/notary/server/src/tee.rs#L31-L38
Check warning on line 46 in crates/notary/server/src/tee.rs
Codecov / codecov/patch
crates/notary/server/src/tee.rs#L42-L46
Check warning on line 49 in crates/notary/server/src/tee.rs
Codecov / codecov/patch
crates/notary/server/src/tee.rs#L49
Check warning on line 55 in crates/notary/server/src/tee.rs
Codecov / codecov/patch
crates/notary/server/src/tee.rs#L53-L55
Check warning on line 66 in crates/notary/server/src/tee.rs
Codecov / codecov/patch
crates/notary/server/src/tee.rs#L64-L66
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sinui0 i wanted to make it explicit that the key can only be set once. so if someone figured out a way to exec the calling function again it couldnt be reset. not sure if thats possible or even if oncecell is the right way to do it
Check warning on line 71 in crates/notary/server/src/tee.rs
Codecov / codecov/patch
crates/notary/server/src/tee.rs#L71
Check warning on line 150 in crates/notary/server/src/tee.rs
Codecov / codecov/patch
crates/notary/server/src/tee.rs#L128-L150
Check warning on line 170 in crates/notary/server/src/tee.rs
Codecov / codecov/patch
crates/notary/server/src/tee.rs#L152-L170
Check warning on line 174 in crates/notary/server/src/tee.rs
Codecov / codecov/patch
crates/notary/server/src/tee.rs#L174