-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lemmy game threads #25
Open
benja810
wants to merge
27
commits into
toddrob99:lemmy-mlb-game-threads
Choose a base branch
from
benja810:lemmy-game-threads
base: lemmy-mlb-game-threads
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lemmy game threads #25
benja810
wants to merge
27
commits into
toddrob99:lemmy-mlb-game-threads
from
benja810:lemmy-game-threads
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODOMy current list
|
Cap the version to maintain compatibility.
Add a stub for the off day thread to prevent runtime errors.
* Fix time calculation for postgame thread update limit * Drop unnecessary stub of off_day
* Make post truncation length a config parameter
Co-authored-by: jspayne <jeff@paynesplace.com>
Use default for POST_CHARACTER_LIMIT Co-authored-by: jspayne <jeff@paynesplace.com>
…lemmy-game-threads
toddrob99
reviewed
Jun 23, 2023
@@ -445,4 +445,15 @@ def upgrade_database(toVer=None): | |||
time.time() | |||
), | |||
], | |||
14: [ | |||
# Add Sidebar Updater bot type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, you saved me the step of doing this... It looks like you forgot to update the comment after copy/pasting though.
Update __init__.py to fix time check for post game thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I created a new bot for game threads in lemmy. The idea is to provide the same game day thread experience that exists currently on the sports subreddits but on lemmy. I am attempting to start with baseball and move on from there.
Notes
I copied the existing
game_threads
bot and all of its templates. I also commented out sticky functionality for the moment and weekly threads.In order to get things working, I need to rip out all the praw references and replace them with my own "plaw" version. This isn't a real praw for lemmy, it's just enough to get the game day bot working minimally.
Known Bugs
The Game Day Thread loop creates a title from its template that has a line break, which isn't allowed in lemmy (API returns an error).