Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add due coloring support #253

Closed
wants to merge 2 commits into from
Closed

add due coloring support #253

wants to merge 2 commits into from

Conversation

krisko
Copy link

@krisko krisko commented May 21, 2018

Hello,
this pull request adds color support for entries with due date in todo.txt.

Usage and test is as simple as creating todo item with due date formated as: due:2018-05-21

mkrissak and others added 2 commits May 21, 2018 17:01
we have to do this simple way, as some shells have issues with [0-9]{x}
@karbassi karbassi requested review from evanp and inkarkat May 22, 2018 16:02
@karbassi
Copy link
Member

karbassi commented May 22, 2018

Thanks @krisko for this wonderful PR. We'll review it and get back to you.

My thoughts are that since due:* isn't part of the native client, I believe this should be part of the due add-on.

Quick question for you @inkarkat & @ginatrapani: can add-ons affect the CLI's highlighting?

@inkarkat
Copy link
Member

Yes, the highlighting can be extended via TODOTXT_FINAL_FILTER. Unlike an add-on, this requires a single line of configuration in todo.cfg; you can't just drop the custom filter in a directory. (The ordering of filters may be important, too, so explicit configuration is the right approach, and not just a case of an automatic approach not being implemented yet.)

So, unless we decide to incorporate the due: prefix in the official spec and the CLI client, this shouldn't be added here. The CLI is so highly configurable, I'd rather continue to keep the core lean and small than opening the gates to adding this and that add-on. Nothing prevents some eager volunteer to assemble a custom distribution of todo.sh that ships with many add-ons and customizations out of the box...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants