Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting of dates, metadata and item numbers #264

Merged
merged 3 commits into from
Mar 29, 2020

Conversation

otizonaizit
Copy link
Contributor

This PR is a refresh of #128 which works with current master.

On top of #128 some simple tests have been added.

I guess this PR makes #253 obsolete, as this is a more general solution?

Thank you for maintaining this great tool!

@otizonaizit otizonaizit changed the title Highlightening of dates, metadata and item numbers Highlighting of dates, metadata and item numbers Nov 23, 2018
@karbassi karbassi requested a review from inkarkat March 29, 2020 18:09
@karbassi
Copy link
Member

Fixes #128
Fixes #253
Resolves #267

@karbassi karbassi merged commit 355166d into todotxt:master Mar 29, 2020
Copy link
Member

@inkarkat inkarkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of adding too much highlighting to the core (and prefer the flexibility of a final filter), but these are generic enough that many users would like it.

wwalker pushed a commit to wwalker/todo.txt-cli that referenced this pull request Sep 19, 2021
* add highlighting of dates, item numbers, and metadata

* add test for highlighting of dates, item numbers, and metadata

Co-authored-by: Ali Karbassi <ali@karbassi.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants