fix(blocks): ime bugs of slash menu and at menu #8444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2ec2744. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
size-limit report 📦
|
L-Sun
force-pushed
the
l-sun/fix/ime-bug-of-slash-menu-at-menu
branch
from
73a3077 to
1d8586b
Compare
fundon
reviewed
Sep 24, 2024
L-Sun
force-pushed
the
l-sun/fix/ime-bug-of-slash-menu-at-menu
branch
from
1d8586b to
83b2bf9
Compare
L-Sun
force-pushed
the
l-sun/fix/ime-bug-of-slash-menu-at-menu
branch
from
83b2bf9 to
8384188
Compare
doodlewind
approved these changes
Sep 24, 2024
Merge activity
|
Close: [BS-1444](https://linear.app/affine-design/issue/BS-1444/在linked-doc面板，输入法输入后，面板消失), [BS-1443](https://linear.app/affine-design/issue/BS-1443/中文输入法下，段落开头输入-【【-无法唤起-linked-doc面板), [BS-1442]( https://linear.app/affine-design/issue/BS-1442/中文输入法下，输入-面板显示位置错误) This PR fixes IME issues of the @ menu and slash menu, including: - Incorrect positioning of the slash menu popover. - Can not open the @ menu using `【【`. - Can not search within the @ menu using IME. The cause of these issues is that, in Windows Microsoft Pinyin, the inline range is updated when the `compositionend` event is triggered. Consequently, the slot `this.inlineEditor.slots.renderComplete.once` and `inlineEditor.slots.inlineRangeSync.once` are delayed until the next keyboard input. Related PR: #7914 ### Before https://github.com/user-attachments/assets/bf9aed3e-e673-437a-8375-7ce219d1d07c ### After https://github.com/user-attachments/assets/4d3eebfd-0869-4051-87e6-c210216b4751
doodlewind
force-pushed
the
l-sun/fix/ime-bug-of-slash-menu-at-menu
branch
from
8384188 to
2ec2744
Compare
graphite-app
bot
deleted the
l-sun/fix/ime-bug-of-slash-menu-at-menu
branch
L-Sun
added a commit
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: BS-1444, BS-1443, BS-1442
This PR fixes IME issues of the @ menu and slash menu, including:
【【.The cause of these issues is that, in Windows Microsoft Pinyin, the inline range is updated when the
compositionendevent is triggered. Consequently, the slotthis.inlineEditor.slots.renderComplete.onceandinlineEditor.slots.inlineRangeSync.onceare delayed until the next keyboard input. Related PR: #7914Before
2024-09-24-17-24-35.mp4
After
2024-09-24-17-27-38.mp4