Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: affine-link supports in-app jumps #8449

Merged
merged 1 commit into from
Sep 25, 2024
Merged

feat: affine-link supports in-app jumps #8449

merged 1 commit into from
Sep 25, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Sep 25, 2024 •
edited
Loading

part of BS-1445

@vercel Vercel
Copy link

vercel bot commented Sep 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 6:45am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2024 6:45am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ea0f51a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 25, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@fundon fundon marked this pull request as ready for review September 25, 2024 01:37
@fundon fundon requested a review from a team as a code owner September 25, 2024 01:37
@fundon Graphite App
Copy link
Contributor Author

fundon commented Sep 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 25, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ea0f51a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited
Loading

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.03 MB (+0.02% 🔺)
@blocksuite/affine/block-std 153.1 KB (0%)
@blocksuite/affine/block-std/gfx 75.86 KB (0%)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.82 KB (0%)
@blocksuite/affine/global/env 231 B (0%)
@blocksuite/affine/global/exceptions 552 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 77.06 KB (0%)
@blocksuite/affine/inline 30.45 KB (0%)
@blocksuite/affine/inline/consts 51 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.84 MB (+0.02% 🔺)
@blocksuite/affine/blocks 1.92 MB (-0.04% 🔽)
@blocksuite/affine/blocks/schemas 85.39 KB (0%)

@fundon fundon force-pushed the fundon/09_25_fix_BS-1445 branch 2 times, most recently from 77ed3f7 to 25ce731 Compare September 25, 2024 01:44
@fundon fundon force-pushed the fundon/09_25_fix_BS-1445 branch from 25ce731 to 83f9476 Compare September 25, 2024 01:46
@fundon fundon added the dont merge Experimental pull requests label Sep 25, 2024
@fundon fundon force-pushed the fundon/09_25_fix_BS-1445 branch from 83f9476 to b615f9a Compare September 25, 2024 02:07
@fundon fundon requested a review from EYHN September 25, 2024 02:09
@fundon fundon force-pushed the fundon/09_25_fix_BS-1445 branch from b615f9a to 04fc597 Compare September 25, 2024 02:17
@fundon fundon force-pushed the fundon/09_25_fix_BS-1445 branch from 04fc597 to 6f74cbd Compare September 25, 2024 02:32
@fundon fundon force-pushed the fundon/09_25_fix_BS-1445 branch from 6f74cbd to 41a9b80 Compare September 25, 2024 02:42
@fundon fundon removed the dont merge Experimental pull requests label Sep 25, 2024
@L-Sun L-Sun added the merge label Sep 25, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 25, 2024 •
edited
Loading

Merge activity

  • Sep 25, 2:43 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 25, 2:43 AM EDT: L-Sun added this pull request to the Graphite merge queue.
  • Sep 25, 2:48 AM EDT: L-Sun merged this pull request with the Graphite merge queue.

@L-Sun L-Sun force-pushed the fundon/09_25_fix_BS-1445 branch from 41a9b80 to ea0f51a Compare September 25, 2024 06:44
@graphite-app graphite-app bot merged commit ea0f51a into master Sep 25, 2024
36 checks passed
@graphite-app graphite-app bot deleted the fundon/09_25_fix_BS-1445 branch September 25, 2024 06:48
@L-Sun L-Sun mentioned this pull request Sep 25, 2024
Merged
L-Sun added a commit that referenced this pull request Sep 25, 2024
@L-Sun
chore: release patch version (#8453)
ce9a242 
Fix bugs and improve experience:
- fix slash menu and @ menu issues with IME [#8444](#8444)
- improve trigger way of latex editor [#8445](#8445)
- support in-app link jump [#8499](#8449)
- some ui improvements [#8446](#8446), [#8450](#8450)
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-Sun L-Sun L-Sun approved these changes

@EYHN EYHN Awaiting requested review from EYHN

Assignees

@fundon fundon

Labels
merge
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fundon @L-Sun