-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-integrate examples into the root workspace #1466
Conversation
This was unintentionally restored in an unrelated PR after initial deletion of the example.
… as non-default members. This reverts commit 1fe4558.
aee2c89
to
d287571
Compare
For me rust-analyzer still checks all the examples which I'd like to avoid. I tried a bunch of ways to set |
This seems to work for me on the latest release: "rust-analyzer.checkOnSave.overrideCommand": [
"cargo",
"check", // or clippy
"--message-format=json",
"--all-targets",
] (cc rust-lang/rust-analyzer#10717, which tracks first-class support for this kind of thing) |
I was able to get it working with that |
Motivation
Currently, when working on axum (with VSCode), you don't get in-editor errors when working on examples. This was caused by #978 moving examples into their own workspace to make development of axum easier, but I've found the opposite to be true.
Solution
Re-integrate the examples into the workspace, this time also setting
default-members
so that they don't get built / checked by a regularcargo check
/cargo build
(only with--workspace
). I hope that retains most of the positives of #978 while fixing its downsides.