Move examples to separate workspace #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpdrsn
force-pushed
the
move-examples-to-separate-workspace
branch
25 times, most recently
from
22dcc5c to
a86ec3a
Compare
davidpdrsn
force-pushed
the
move-examples-to-separate-workspace
branch
from
a86ec3a to
073db16
Compare
davidpdrsn
changed the title
jplatte
reviewed
Apr 29, 2022
jplatte
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something I've been considering for some time. The examples folder is slowly getting bigger and gaining more dependencies. Thats not bad in and off itself however it makes developing axum itself slower since there are more crates for rust-analyzer to build.
So I suggest we move the examples into their own workspace so they need to be compiled separately.
Everything is still checked on CI.