Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add block_on to Handle #3096

Closed
Darksonn opened this issue Nov 5, 2020 · 2 comments
Closed

Add block_on to Handle #3096

Darksonn opened this issue Nov 5, 2020 · 2 comments
Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request. M-runtime Module: tokio/runtime

Comments

@Darksonn
Copy link
Contributor

Darksonn commented Nov 5, 2020 •
edited
Loading

As a follow-up to #3076, we should add block_on to Handle. This would close #2965.

cc @Keruspe
@Darksonn Darksonn added A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime C-feature-request Category: A feature request. labels Nov 5, 2020
@Darksonn Darksonn mentioned this issue Nov 5, 2020
Closed
@Keruspe Keruspe mentioned this issue Nov 5, 2020
Closed
@sunjay sunjay mentioned this issue Dec 14, 2020
Open
5 tasks
@carllerche carllerche mentioned this issue Feb 23, 2021
Closed
@davidpdrsn davidpdrsn mentioned this issue Mar 1, 2021
Merged
davidpdrsn added a commit that referenced this issue Mar 20, 2021
@davidpdrsn
runtime: add Handle::block_on (#3569)
c39d986 
Add `runtime::Handle::block_on`. The function enters the runtime context and
blocks the current thread while the future executes.

Refs: #3097
Fixes #2965, #3096
@pickfire
Copy link
Contributor

I believe this should be resolved?

@davidpdrsn
Copy link
Member

Yes. Fixed in #3569 and released as part of 1.4.0.

@stuhood stuhood mentioned this issue Mar 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request. M-runtime Module: tokio/runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rt: move block_on to handle Keruspe/tokio
3 participants
@davidpdrsn @Darksonn @pickfire