-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prepare Tokio v1.8.4 #4237
Merged
Merged
Commits on Nov 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 0c83c37 - Browse repository at this point
Copy the full SHA 0c83c37View commit details -
oneshot: document UnsafeCell invariants (#4229)
Depends on #4226 ## Motivation Currently, the safety invariants and synchronization strategy used in `tokio::sync::oneshot` are not particularly obvious, especially to a new reader. It would be nice to better document this code to make these invariants clearer. ## Solution This branch adds `SAFETY:` comments to the `oneshot` channel implementation. In particular, I've focused on documenting the invariants around when the inner `UnsafeCell` that stores the value can be accessed by the sender and receiver sides of the channel. I still want to take a closer look at when the waker cells can be set, and I'd like to add more documentation there in a follow-up branch. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Configuration menu - View commit details
-
Copy full SHA for 3877e71 - Browse repository at this point
Copy the full SHA 3877e71View commit details
Commits on Nov 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a6b447a - Browse repository at this point
Copy the full SHA a6b447aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a609bb0 - Browse repository at this point
Copy the full SHA a609bb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75cd90c - Browse repository at this point
Copy the full SHA 75cd90cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba3b5bd - Browse repository at this point
Copy the full SHA ba3b5bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for c53695c - Browse repository at this point
Copy the full SHA c53695cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b8c899b - Browse repository at this point
Copy the full SHA b8c899bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff2c6fc - Browse repository at this point
Copy the full SHA ff2c6fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc947af - Browse repository at this point
Copy the full SHA cc947afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 88ffea6 - Browse repository at this point
Copy the full SHA 88ffea6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82a1352 - Browse repository at this point
Copy the full SHA 82a1352View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc15532 - Browse repository at this point
Copy the full SHA bc15532View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33680e6 - Browse repository at this point
Copy the full SHA 33680e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a5d086 - Browse repository at this point
Copy the full SHA 9a5d086View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6917e5c - Browse repository at this point
Copy the full SHA 6917e5cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.