Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenTelemetry 0.24 #154

Closed
NOBLES5E opened this issue Jul 13, 2024 · 6 comments
Closed

Support OpenTelemetry 0.24 #154

NOBLES5E opened this issue Jul 13, 2024 · 6 comments

Comments

@NOBLES5E
Copy link

The upcoming release of OpenTelemetry 0.24 (open-telemetry/opentelemetry-rust#1932) introduces breaking changes that affect the current implementation of tracing-opentelemetry.

Please update tracing-opentelemetry to support OpenTelemetry 0.24. This will ensure continued compatibility and allow users to benefit from the latest OpenTelemetry features and improvements.

@djc
Copy link
Collaborator

djc commented Jul 13, 2024

Of course we will. Are you able to submit a PR?

@NOBLES5E
Copy link
Author

I've encountered a challenge: OpenTelemetry 0.24 has made Tracer::provider() private, which impacts the current implementation. Given my limited familiarity with the tracing-opentelemetry codebase, I'm not confident in proposing a workaround for this change.

@djc
Copy link
Collaborator

djc commented Jul 13, 2024

I wrote up some feedback for upstream here:

open-telemetry/opentelemetry-rust#1755 (comment)

timzaak added a commit to ForNetCode/spa-server that referenced this issue Jul 13, 2024
@NOBLES5E
Copy link
Author

Today opentelemetry 0.24 was released. However the sampler is still private which seems to break this line:

builder.sampling_result = Some(provider.config().sampler.should_sample(

@djc
Copy link
Collaborator

djc commented Jul 15, 2024

Thanks for letting me know. See #155 and open-telemetry/opentelemetry-rust#1937.

@NOBLES5E
Copy link
Author

NOBLES5E commented Aug 2, 2024

Thanks!

@NOBLES5E NOBLES5E closed this as completed Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants