Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to opentelemetry 0.24 #155

Merged
merged 4 commits into from
Jul 21, 2024
Merged

Upgrade to opentelemetry 0.24 #155

merged 4 commits into from
Jul 21, 2024

Conversation

djc
Copy link
Collaborator

@djc djc commented Jul 15, 2024

@djc djc force-pushed the otel-0.24 branch 2 times, most recently from 4e58c47 to 71ed939 Compare July 18, 2024 10:20
Cargo.toml Show resolved Hide resolved
@djc
Copy link
Collaborator Author

djc commented Jul 18, 2024

@mladedav or @jtescher do you want to review this?

I plan to merge this in ~24 hours, happy to take feedback after merge too though.

Copy link
Contributor

@mladedav mladedav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope to still look into the changes in opentelemetry itself, I think I'm missing bits of context there but if I take those at face value this seems good to me.

examples/opentelemetry-otlp.rs Outdated Show resolved Hide resolved
examples/opentelemetry-otlp.rs Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@djc
Copy link
Collaborator Author

djc commented Jul 18, 2024

I hope to still look into the changes in opentelemetry itself, I think I'm missing bits of context there but if I take those at face value this seems good to me.

Thanks for the review -- this is great, I'll hold off until you've had a chance to gather more context (or let me know if you won't have time to do so, that's fine too of course!).

Copy link
Contributor

@mladedav mladedav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for figuring this out

@djc djc merged commit 83adbff into v0.1.x Jul 21, 2024
15 checks passed
@djc
Copy link
Collaborator Author

djc commented Jul 21, 2024

@mladedav thanks for the review!

@djc
Copy link
Collaborator Author

djc commented Jul 21, 2024

  • Published tracing-opentelemetry v0.25.0 at registry crates-io
  • [new tag] v0.25.0 -> v0.25.0
  • Release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants