Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracing_subscriber::filter::ParseError no longer publicly visible with version 0.2.21 #1557

Closed
adoerr opened this issue Sep 13, 2021 · 2 comments
Closed

tracing_subscriber::filter::ParseError no longer publicly visible with version 0.2.21 #1557

adoerr opened this issue Sep 13, 2021 · 2 comments

Comments

@adoerr
Copy link

adoerr commented Sep 13, 2021

This might be a regression.

tracing_subscriber::filter::ParseError stopped to be publicly visible/accessible with version 0.2.21. It was with version 0.2.20 and below.

This can also easily be checked by looking at the Doc

0.2.20

vs

0.2.21
@hawkw
Copy link
Member

hawkw commented Sep 13, 2021

Yup, that's definitely a regression. I accidentally renamed this type in PR #1550 after getting confused by a renaming import...sorry about that. We'll get a new release out that fixes that right away!

@hawkw hawkw mentioned this issue Sep 13, 2021
Merged
hawkw added a commit that referenced this issue Sep 13, 2021
@hawkw
subscriber: fix filter::ParseError accidentally being renamed (#1558)
6df3fd1 
I accidentally renamed this type in PR #1550 after getting confused by a
renaming import that I thought was publicly re-exported, but it wasn't
actually..sorry about that!

This commit renames (or...un-renames?) the type. Whoopsie!

Fixes #1557
@hawkw
Copy link
Member

hawkw commented Sep 13, 2021

Okay, I've released v0.2.22 and yanked v0.2.21 to hopefully minimize the breakage for other users. Thanks for the bug report, and sorry for any inconvenience!

@hawkw hawkw closed this as completed Sep 13, 2021
@guillemcordoba guillemcordoba mentioned this issue Sep 14, 2021
Closed
davidbarsky pushed a commit that referenced this issue Nov 29, 2021
@hawkw @davidbarsky
subscriber: fix filter::ParseError accidentally being renamed (#1558)
a530220 
I accidentally renamed this type in PR #1550 after getting confused by a
renaming import that I thought was publicly re-exported, but it wasn't
actually..sorry about that!

This commit renames (or...un-renames?) the type. Whoopsie!

Fixes #1557
hawkw added a commit that referenced this issue Mar 23, 2022
@hawkw
subscriber: fix filter::ParseError accidentally being renamed (#1558)
b736249 
I accidentally renamed this type in PR #1550 after getting confused by a
renaming import that I thought was publicly re-exported, but it wasn't
actually..sorry about that!

This commit renames (or...un-renames?) the type. Whoopsie!

Fixes #1557
hawkw added a commit that referenced this issue Mar 23, 2022
@hawkw
subscriber: fix filter::ParseError accidentally being renamed (#1558)
61f5e63 
I accidentally renamed this type in PR #1550 after getting confused by a
renaming import that I thought was publicly re-exported, but it wasn't
actually..sorry about that!

This commit renames (or...un-renames?) the type. Whoopsie!

Fixes #1557
hawkw added a commit that referenced this issue Mar 24, 2022
@hawkw
subscriber: fix filter::ParseError accidentally being renamed (#1558)
10b0c91 
I accidentally renamed this type in PR #1550 after getting confused by a
renaming import that I thought was publicly re-exported, but it wasn't
actually..sorry about that!

This commit renames (or...un-renames?) the type. Whoopsie!

Fixes #1557
hawkw added a commit that referenced this issue Mar 24, 2022
@hawkw
subscriber: fix filter::ParseError accidentally being renamed (#1558)
7b46fc2 
I accidentally renamed this type in PR #1550 after getting confused by a
renaming import that I thought was publicly re-exported, but it wasn't
actually..sorry about that!

This commit renames (or...un-renames?) the type. Whoopsie!

Fixes #1557
hawkw added a commit that referenced this issue Mar 24, 2022
@hawkw
subscriber: fix filter::ParseError accidentally being renamed (#1558)
51fbc1a 
I accidentally renamed this type in PR #1550 after getting confused by a
renaming import that I thought was publicly re-exported, but it wasn't
actually..sorry about that!

This commit renames (or...un-renames?) the type. Whoopsie!

Fixes #1557
hawkw added a commit that referenced this issue Mar 24, 2022
@hawkw
subscriber: fix filter::ParseError accidentally being renamed (#1558)
1d765de 
I accidentally renamed this type in PR #1550 after getting confused by a
renaming import that I thought was publicly re-exported, but it wasn't
actually..sorry about that!

This commit renames (or...un-renames?) the type. Whoopsie!

Fixes #1557
hawkw added a commit that referenced this issue Mar 24, 2022
@hawkw
subscriber: fix filter::ParseError accidentally being renamed (#1558)
18fe264 
I accidentally renamed this type in PR #1550 after getting confused by a
renaming import that I thought was publicly re-exported, but it wasn't
actually..sorry about that!

This commit renames (or...un-renames?) the type. Whoopsie!

Fixes #1557
hawkw added a commit that referenced this issue Mar 24, 2022
@hawkw
subscriber: fix filter::ParseError accidentally being renamed (#1558)
67de655 
I accidentally renamed this type in PR #1550 after getting confused by a
renaming import that I thought was publicly re-exported, but it wasn't
actually..sorry about that!

This commit renames (or...un-renames?) the type. Whoopsie!

Fixes #1557
hawkw added a commit that referenced this issue Mar 24, 2022
@hawkw
subscriber: fix filter::ParseError accidentally being renamed (#1558)
7d5c88f 
I accidentally renamed this type in PR #1550 after getting confused by a
renaming import that I thought was publicly re-exported, but it wasn't
actually..sorry about that!

This commit renames (or...un-renames?) the type. Whoopsie!

Fixes #1557
hawkw added a commit that referenced this issue Mar 24, 2022
@hawkw
subscriber: fix filter::ParseError accidentally being renamed (#1558)
a51e8f3 
I accidentally renamed this type in PR #1550 after getting confused by a
renaming import that I thought was publicly re-exported, but it wasn't
actually..sorry about that!

This commit renames (or...un-renames?) the type. Whoopsie!

Fixes #1557
kaffarell pushed a commit to kaffarell/tracing that referenced this issue May 22, 2024
@hawkw @kaffarell
subscriber: fix filter::ParseError accidentally being renamed (toki…
ea501e5 
…o-rs#1558)

I accidentally renamed this type in PR tokio-rs#1550 after getting confused by a
renaming import that I thought was publicly re-exported, but it wasn't
actually..sorry about that!

This commit renames (or...un-renames?) the type. Whoopsie!

Fixes tokio-rs#1557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hawkw @adoerr