subscriber: fix filter::ParseError accidentally being renamed #1558
+27
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I accidentally renamed this type in PR #1550 after getting confused by a renaming import that I thought was publicly re-exported, but it wasn't actually..sorry about that! This commit renames (or...un-renames?) the type. Whoopsie!
davidbarsky
approved these changes
Sep 13, 2021
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
…o-rs#1558) I accidentally renamed this type in PR tokio-rs#1550 after getting confused by a renaming import that I thought was publicly re-exported, but it wasn't actually..sorry about that! This commit renames (or...un-renames?) the type. Whoopsie! Fixes tokio-rs#1557
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
# 0.2.22 (September 13, 2021) This fixes a regression where the `filter::ParseError` type was accidentally renamed. ### Fixed - **filter**: Fix `filter::ParseError` accidentally being renamed to `filter::DirectiveParseError` ([tokio-rs#1558]) [tokio-rs#1558]: tokio-rs#1558
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally renamed this type in PR #1550 after getting confused by a
renaming import that I thought was publicly re-exported, but it wasn't
actually..sorry about that!
This commit renames (or...un-renames?) the type. Whoopsie!
Fixes #1557