Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appender(docs): fix minor typo for DEFAULT_BUFFERED_LINES_LIMIT #1109

Merged
merged 1 commit into from
Nov 17, 2020
Merged

appender(docs): fix minor typo for DEFAULT_BUFFERED_LINES_LIMIT #1109

merged 1 commit into from
Nov 17, 2020

Conversation

salewski
Copy link
Contributor

Remove duplication in "...at capacity. capacity." in doc comment for:

tracing_appender::non_blocking::DEFAULT_BUFFERED_LINES_LIMIT

@salewski
appender(docs): fix minor typo for DEFAULT_BUFFERED_LINES_LIMIT
32aae2e 
Remove duplication in "...at capacity. capacity." in doc comment for:

    tracing_appender::non_blocking::DEFAULT_BUFFERED_LINES_LIMIT
@salewski salewski requested a review from a team as a code owner November 17, 2020 00:15
davidbarsky
davidbarsky approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@davidbarsky davidbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, thanks!

@davidbarsky davidbarsky merged commit ebab369 into tokio-rs:master Nov 17, 2020
hawkw pushed a commit that referenced this pull request Dec 28, 2020
@salewski @hawkw
docs: fix minor typo for DEFAULT_BUFFERED_LINES_LIMIT (#1109)
eaf9959
hawkw pushed a commit that referenced this pull request Dec 29, 2020
@salewski @hawkw
docs: fix minor typo for DEFAULT_BUFFERED_LINES_LIMIT (#1109)
9549be9
hawkw added a commit that referenced this pull request Dec 29, 2020
@hawkw
appender: prepare to release v0.1.2
a752385 
Changed

- **non_blocking**: Updated `crossbeam-channel` dependency to 0.5
  (#1031)

Fixed
- **non_blocking**: Fixed a race condition when logging on shutdown
  (#1125)
- Several documentation improvements (#1109, #1110, #941, #953)
@hawkw hawkw mentioned this pull request Dec 29, 2020
Merged
hawkw added a commit that referenced this pull request Dec 29, 2020
@hawkw
appender: prepare to release v0.1.2 (#1157)
6ce7189 
Changed

- **non_blocking**: Updated `crossbeam-channel` dependency to 0.5
  (#1031)

Fixed
- **non_blocking**: Fixed a race condition when logging on shutdown
  (#1125)
- Several documentation improvements (#1109, #1110, #941, #953)
@jonhoo jonhoo mentioned this pull request Jan 12, 2021
Closed
@davidbarsky davidbarsky mentioned this pull request Sep 26, 2023
Merged
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
@hawkw @kaffarell
appender: prepare to release v0.1.2 (tokio-rs#1157)
f18931f 
Changed

- **non_blocking**: Updated `crossbeam-channel` dependency to 0.5
  (tokio-rs#1031)

Fixed
- **non_blocking**: Fixed a race condition when logging on shutdown
  (tokio-rs#1125)
- Several documentation improvements (tokio-rs#1109, tokio-rs#1110, tokio-rs#941, tokio-rs#953)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbarsky davidbarsky davidbarsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salewski @davidbarsky