appender(docs): add missing entry for Rotation::MINUTELY #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list introduced by:
"To use a Rotation, pick one of the following options:"
had en entry for all variations of Rotation except for
Rotation::MINUTELY. This changeset completes this list, with the doc
test structured the same as the others in the list.
davidbarsky
approved these changes
Nov 17, 2020
hawkw
pushed a commit
that referenced
this pull request
Dec 28, 2020
hawkw
pushed a commit
that referenced
this pull request
Dec 29, 2020
hawkw
added a commit
that referenced
this pull request
Dec 29, 2020
hawkw
added a commit
that referenced
this pull request
Dec 29, 2020
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
Changed - **non_blocking**: Updated `crossbeam-channel` dependency to 0.5 (tokio-rs#1031) Fixed - **non_blocking**: Fixed a race condition when logging on shutdown (tokio-rs#1125) - Several documentation improvements (tokio-rs#1109, tokio-rs#1110, tokio-rs#941, tokio-rs#953)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list introduced by:
had en entry for all variations of Rotation except for Rotation::MINUTELY. This PR completes this list, with the doc test structured the same as the others in the list.
The newly added entry heading is "Minutely Rotation".
Side-note: I had to look up "minutely" in several dictionaries to convince myself that it is actually a legit English word that means "minute by minute" (in addition to the more familiar definition meaning "careful examination"), and was not just a cute symbol name in the code. It turns out that that usage of the word is legit! (But you folks already knew that) :-)
I performed both positive and negative tests to ensure that
'cargo test --doc'is correctly testing the change.