-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appender: replace chrono with time #1652
Merged
Merged
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9b286b5
appender: replace chrono with time
davidbarsky 37b1a66
Merge branch 'master' into davidbarsky/once-upon-a-time-in-tracing
hawkw 1543937
address review comments
davidbarsky 8ae80db
got rid of macros
davidbarsky 4b16534
exclude tracing-appender from tracing's msrv because of `time`
davidbarsky a328fcd
Merge branch 'master' into davidbarsky/once-upon-a-time-in-tracing
davidbarsky 31d9b5f
update MSRV + add a check for appender
davidbarsky 1a636a9
Merge branch 'davidbarsky/once-upon-a-time-in-tracing' of https://git…
davidbarsky 7d80650
Merge branch 'master' into davidbarsky/once-upon-a-time-in-tracing
davidbarsky a629369
Update .github/workflows/CI.yml
davidbarsky c4ad667
i think the msrv is updated?
davidbarsky 43ba284
Merge branch 'davidbarsky/once-upon-a-time-in-tracing' of https://git…
davidbarsky 37634fc
address nits
davidbarsky cba41f1
Merge branch 'master' into davidbarsky/once-upon-a-time-in-tracing
davidbarsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also update the MSRV in
tracing-appender
's documentation & readme?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup!