appender: replace chrono with time #1652

davidbarsky · 2021-10-19T19:21:29Z

Motivation

This PR continues the work started in #1646 to replace chrono with time. I'll refer to @hawkw's motivation:

Currently, tracing-subscriber supports the chrono crate for timestamp formatting, via a default-on feature flag. When this code was initially added to tracing-subscriber, the time crate did not have support for the timestamp formatting options we needed.

Unfortunately, the chrono crate's maintenance status is now in question (see #1598). Furthermore, chrono depends on version 0.1 of the time crate, which contains a security vulnerability (https://rustsec.org/advisories/RUSTSEC-2020-0071.html). This vulnerability is fixed in more recent releases of time, but chrono still uses v0.1.

Solution

I've replaced chrono with time 0.3. Unfortunately, some of chrono's builders for DateTimes are not present in time, which required the usage of macro_rules! macros to construct some of the hard-coded times. I also took the opportunity to tidy some of the tests and change the internal representation of Rotation::NEVER from year 9,999 to an Option::None.

tracing-appender/Cargo.toml

tracing-appender/src/inner.rs

tracing-appender/src/rolling.rs

hawkw · 2021-10-19T22:59:50Z

hmm looks like including the macros as a dev dependency still breaks MSRV. can we drop them from the tests as well?

hawkw

overall, LGTM; can we update the tracing-appender MSRV docs before merging this?

hawkw · 2021-10-21T19:44:58Z

.github/workflows/CI.yml

@@ -21,7 +21,7 @@ jobs:
      uses: actions-rs/cargo@v1
      with:
        command: check
-        args: --all
+        args: --all --exclude=tracing-appender


can we also update the MSRV in tracing-appender's documentation & readme?

tracing-appender/src/rolling.rs

…hub.com/tokio-rs/tracing into davidbarsky/once-upon-a-time-in-tracing

hawkw

MSRV docs need to be updated in a couple additional places; modulo that, this LGTM

.github/workflows/CI.yml

tracing-appender/README.md

Co-authored-by: Eliza Weisman <eliza@buoyant.io>

…hub.com/tokio-rs/tracing into davidbarsky/once-upon-a-time-in-tracing

hawkw

okay, this looks great to me!

up to you, but i don't think it's really necessary to mention the project MSRV for other crates in the MSRV docs for tracing-appender. it could just be simplified to discuss that crate.

not a blocker though.

tracing-appender/src/lib.rs

tracing-appender/README.md

@hawkw

## Motivation This PR continues the work started in #1646 to replace `chrono` with `time`. I'll refer to @hawkw's motivation: > Currently, `tracing-subscriber` supports the `chrono` crate for > timestamp formatting, via a default-on feature flag. When this code > was initially added to `tracing-subscriber`, the `time` crate did not > have support for the timestamp formatting options we needed. > > Unfortunately, the `chrono` crate's maintenance status is now in > question (see #1598). Furthermore, `chrono` depends on version 0.1 of > the `time` crate, which contains a security vulnerability > (https://rustsec.org/advisories/RUSTSEC-2020-0071.html). This > vulnerability is fixed in more recent releases of `time`, but `chrono` > still uses v0.1. ## Solution I've replaced chrono with time 0.3. Unfortunately, some of chrono's builders for DateTimes are not present in `time`, which required the usage of `macro_rules!` macros to construct some of the hard-coded times. I also took the opportunity to tidy some of the tests and change the internal representation of `Rotation::NEVER` from year 9,999 to an `Option::None`. This branch changes `tracing-appender`'s MSRV from Rust 1.42 to Rust 1.51, the MSRV for the `time` crate when certain required feature flags are enabled. This does *not* effect the MSRV for other crates in this repository.

@hawkw

## Motivation This PR continues the work started in #1646 to replace `chrono` with `time`. I'll refer to @hawkw's motivation: > Currently, `tracing-subscriber` supports the `chrono` crate for > timestamp formatting, via a default-on feature flag. When this code > was initially added to `tracing-subscriber`, the `time` crate did not > have support for the timestamp formatting options we needed. > > Unfortunately, the `chrono` crate's maintenance status is now in > question (see #1598). Furthermore, `chrono` depends on version 0.1 of > the `time` crate, which contains a security vulnerability > (https://rustsec.org/advisories/RUSTSEC-2020-0071.html). This > vulnerability is fixed in more recent releases of `time`, but `chrono` > still uses v0.1. ## Solution I've replaced chrono with time 0.3. Unfortunately, some of chrono's builders for DateTimes are not present in `time`, which required the usage of `macro_rules!` macros to construct some of the hard-coded times. I also took the opportunity to tidy some of the tests and change the internal representation of `Rotation::NEVER` from year 9,999 to an `Option::None`. This branch changes `tracing-appender`'s MSRV from Rust 1.42 to Rust 1.51, the MSRV for the `time` crate when certain required feature flags are enabled. This does *not* effect the MSRV for other crates in this repository.

@dzvon

# 0.2.0 (October 22, 2021) This breaking change release adds support for the new v0.3.x series of `tracing-subscriber`. In addition, it resolves the security advisory for the `chrono` crate, [RUSTSEC-2020-0159]. This release increases the minimum supported Rust version (MSRV) to 1.51.0. ### Breaking Changes - Updated `tracing-subscriber` to v0.3.x ([#1677]) - Changed `NonBlocking::error_counter` to return an `ErrorCounter` type, rather than an `Arc<AtomicU64>` ([#1675]) ### Changed - Updated `tracing-subscriber` to v0.3.x ([#1677]) ### Fixed - **non-blocking**: Fixed compilation on 32-bit targets ([#1675]) - **rolling**: Replaced `chrono` dependency with `time` to resolve [RUSTSEC-2020-0159] ([#1652]) - **rolling**: Fixed an issue where `RollingFileAppender` would fail to print errors that occurred while flushing a previous logfile ([#1604]) Thanks to new contributors @dzvon and @zvkemp for contributing to this release! [RUSTSEC-2020-0159]: https://rustsec.org/advisories/RUSTSEC-2020-0159.html [#1677]: #1677 [#1675]: #1675 [#1652]: #1675 [#1604]: #1604

@dzvon

# 0.2.0 (October 22, 2021) This breaking change release adds support for the new v0.3.x series of `tracing-subscriber`. In addition, it resolves the security advisory for the `chrono` crate, [RUSTSEC-2020-0159]. This release increases the minimum supported Rust version (MSRV) to 1.51.0. ### Breaking Changes - Updated `tracing-subscriber` to v0.3.x ([#1677]) - Changed `NonBlocking::error_counter` to return an `ErrorCounter` type, rather than an `Arc<AtomicU64>` ([#1675]) ### Changed - Updated `tracing-subscriber` to v0.3.x ([#1677]) ### Fixed - **non-blocking**: Fixed compilation on 32-bit targets ([#1675]) - **rolling**: Replaced `chrono` dependency with `time` to resolve [RUSTSEC-2020-0159] ([#1652]) - **rolling**: Fixed an issue where `RollingFileAppender` would fail to print errors that occurred while flushing a previous logfile ([#1604]) Thanks to new contributors @dzvon and @zvkemp for contributing to this release! [RUSTSEC-2020-0159]: https://rustsec.org/advisories/RUSTSEC-2020-0159.html [#1677]: #1677 [#1675]: #1675 [#1652]: #1675 [#1604]: #1604

@hawkw

This PR continues the work started in tokio-rs#1646 to replace `chrono` with `time`. I'll refer to @hawkw's motivation: > Currently, `tracing-subscriber` supports the `chrono` crate for > timestamp formatting, via a default-on feature flag. When this code > was initially added to `tracing-subscriber`, the `time` crate did not > have support for the timestamp formatting options we needed. > > Unfortunately, the `chrono` crate's maintenance status is now in > question (see tokio-rs#1598). Furthermore, `chrono` depends on version 0.1 of > the `time` crate, which contains a security vulnerability > (https://rustsec.org/advisories/RUSTSEC-2020-0071.html). This > vulnerability is fixed in more recent releases of `time`, but `chrono` > still uses v0.1. I've replaced chrono with time 0.3. Unfortunately, some of chrono's builders for DateTimes are not present in `time`, which required the usage of `macro_rules!` macros to construct some of the hard-coded times. I also took the opportunity to tidy some of the tests and change the internal representation of `Rotation::NEVER` from year 9,999 to an `Option::None`. This branch changes `tracing-appender`'s MSRV from Rust 1.42 to Rust 1.51, the MSRV for the `time` crate when certain required feature flags are enabled. This does *not* effect the MSRV for other crates in this repository.

@dzvon

# 0.2.0 (October 22, 2021) This breaking change release adds support for the new v0.3.x series of `tracing-subscriber`. In addition, it resolves the security advisory for the `chrono` crate, [RUSTSEC-2020-0159]. This release increases the minimum supported Rust version (MSRV) to 1.51.0. ### Breaking Changes - Updated `tracing-subscriber` to v0.3.x ([tokio-rs#1677]) - Changed `NonBlocking::error_counter` to return an `ErrorCounter` type, rather than an `Arc<AtomicU64>` ([tokio-rs#1675]) ### Changed - Updated `tracing-subscriber` to v0.3.x ([tokio-rs#1677]) ### Fixed - **non-blocking**: Fixed compilation on 32-bit targets ([tokio-rs#1675]) - **rolling**: Replaced `chrono` dependency with `time` to resolve [RUSTSEC-2020-0159] ([tokio-rs#1652]) - **rolling**: Fixed an issue where `RollingFileAppender` would fail to print errors that occurred while flushing a previous logfile ([tokio-rs#1604]) Thanks to new contributors @dzvon and @zvkemp for contributing to this release! [RUSTSEC-2020-0159]: https://rustsec.org/advisories/RUSTSEC-2020-0159.html [tokio-rs#1677]: tokio-rs#1677 [tokio-rs#1675]: tokio-rs#1675 [tokio-rs#1652]: tokio-rs#1675 [tokio-rs#1604]: tokio-rs#1604

appender: replace chrono with time

9b286b5

davidbarsky requested a review from a team as a code owner October 19, 2021 19:21

davidbarsky self-assigned this Oct 19, 2021

davidbarsky requested a review from hawkw October 19, 2021 19:26

hawkw reviewed Oct 19, 2021

View reviewed changes

hawkw and others added 2 commits October 19, 2021 14:56

Merge branch 'master' into davidbarsky/once-upon-a-time-in-tracing

37b1a66

address review comments

1543937

davidbarsky and others added 3 commits October 19, 2021 19:31

got rid of macros

8ae80db

exclude tracing-appender from tracing's msrv because of time

4b16534

Merge branch 'master' into davidbarsky/once-upon-a-time-in-tracing

a328fcd

hawkw approved these changes Oct 21, 2021

View reviewed changes

davidbarsky and others added 3 commits October 21, 2021 18:41

update MSRV + add a check for appender

31d9b5f

Merge branch 'davidbarsky/once-upon-a-time-in-tracing' of https://git…

1a636a9

…hub.com/tokio-rs/tracing into davidbarsky/once-upon-a-time-in-tracing

Merge branch 'master' into davidbarsky/once-upon-a-time-in-tracing

7d80650

hawkw requested changes Oct 21, 2021

View reviewed changes

.github/workflows/CI.yml Outdated Show resolved Hide resolved

tracing-appender/README.md Show resolved Hide resolved

davidbarsky and others added 3 commits October 21, 2021 20:52

Update .github/workflows/CI.yml

a629369

Co-authored-by: Eliza Weisman <eliza@buoyant.io>

i think the msrv is updated?

c4ad667

Merge branch 'davidbarsky/once-upon-a-time-in-tracing' of https://git…

43ba284

…hub.com/tokio-rs/tracing into davidbarsky/once-upon-a-time-in-tracing

hawkw approved these changes Oct 22, 2021

View reviewed changes

tracing-appender/src/lib.rs Outdated Show resolved Hide resolved

tracing-appender/README.md Outdated Show resolved Hide resolved

davidbarsky and others added 2 commits October 22, 2021 13:33

address nits

37634fc

Merge branch 'master' into davidbarsky/once-upon-a-time-in-tracing

cba41f1

hawkw merged commit 336f8ca into master Oct 22, 2021

hawkw deleted the davidbarsky/once-upon-a-time-in-tracing branch October 22, 2021 17:46

hawkw mentioned this pull request Oct 22, 2021

remaining backports for tracing-subscriber 0.3 #1676

Merged

complexspaces mentioned this pull request Mar 11, 2022

Port from chrono to time 0.3 shssoichiro/zxcvbn-rs#63

Closed

davidbarsky mentioned this pull request Sep 26, 2023

chore: backport roughly a year's worth of changes #2728

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

appender: replace chrono with time #1652

appender: replace chrono with time #1652

davidbarsky commented Oct 19, 2021

hawkw commented Oct 19, 2021

hawkw left a comment

hawkw Oct 21, 2021

davidbarsky Oct 21, 2021

hawkw left a comment

hawkw left a comment

appender: replace chrono with time #1652

appender: replace chrono with time #1652

Conversation

davidbarsky commented Oct 19, 2021

Motivation

Solution

hawkw commented Oct 19, 2021

hawkw left a comment

Choose a reason for hiding this comment

hawkw Oct 21, 2021

Choose a reason for hiding this comment

davidbarsky Oct 21, 2021

Choose a reason for hiding this comment

hawkw left a comment

Choose a reason for hiding this comment

hawkw left a comment

Choose a reason for hiding this comment