Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appender: replace chrono with time #1652

Merged
merged 14 commits into from
Oct 22, 2021
Merged

appender: replace chrono with time #1652

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9b286b5
appender: replace chrono with time
davidbarsky Oct 19, 2021
37b1a66
Merge branch 'master' into davidbarsky/once-upon-a-time-in-tracing
hawkw Oct 19, 2021
1543937
address review comments
davidbarsky Oct 19, 2021
8ae80db
got rid of macros
davidbarsky Oct 19, 2021
4b16534
exclude tracing-appender from tracing's msrv because of `time`
davidbarsky Oct 19, 2021
a328fcd
Merge branch 'master' into davidbarsky/once-upon-a-time-in-tracing
davidbarsky Oct 21, 2021
31d9b5f
update MSRV + add a check for appender
davidbarsky Oct 21, 2021
1a636a9
Merge branch 'davidbarsky/once-upon-a-time-in-tracing' of https://git…
davidbarsky Oct 21, 2021
7d80650
Merge branch 'master' into davidbarsky/once-upon-a-time-in-tracing
davidbarsky Oct 21, 2021
a629369
Update .github/workflows/CI.yml
davidbarsky Oct 22, 2021
c4ad667
i think the msrv is updated?
davidbarsky Oct 22, 2021
43ba284
Merge branch 'davidbarsky/once-upon-a-time-in-tracing' of https://git…
davidbarsky Oct 22, 2021
37634fc
address nits
davidbarsky Oct 22, 2021
cba41f1
Merge branch 'master' into davidbarsky/once-upon-a-time-in-tracing
davidbarsky Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
uses: actions-rs/cargo@v1
with:
command: check
args: --all
args: --all --exclude=tracing-appender
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also update the MSRV in tracing-appender's documentation & readme?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup!


check:
# Run `cargo check` first to ensure that the pushed code at least compiles.
Expand Down