Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes for yandex music which led to an error when loading a track or playlist #31

Merged
merged 3 commits into from
Nov 17, 2022

Conversation

BrokenFG
Copy link
Contributor

Fix error when track doesn't have cover
Fix error when track is not available
Fix error when track doesn't include in any albums (for example user uploaded track manually)

Fix error when track is not available
Fix error when track doesn't include in any albums (for example user uploaded track manually)
Copy link
Owner

@topi314 topi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else looks good. I assume you tested this as i can't

@topi314
Copy link
Owner

topi314 commented Nov 16, 2022

@AgutinVBoy please also have a look

@topi314
Copy link
Owner

topi314 commented Nov 16, 2022

Fix error when track doesn't include in any albums (for example user uploaded track manually)

can we not stream it in this case?

Fix error when track is not available
Fix error when track doesn't include in any albums (for example user uploaded track manually)
@BrokenFG
Copy link
Contributor Author

Fix error when track doesn't include in any albums (for example user uploaded track manually)

can we not stream it in this case?

We won't, we check the track for availability and for its presence in the album, if any of these conditions are not met, we skip this track

@BrokenFG
Copy link
Contributor Author

I assume you tested this as i can't

I came across these errors when trying to play my playlist, after these changes everything works fine for me

@AgutinVBoy
Copy link
Contributor

Fix error when track doesn't include in any albums (for example user uploaded track manually)

Can you provide a case? When I tested the library, I could not get any local track in response.

Copy link
Owner

@topi314 topi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from me. will wait for @AgutinVBoy before merging

@AgutinVBoy
Copy link
Contributor

Good fix. I have no complaints (only one review and one question)
@TopiSenpai

Fix error when track doesn't include in any albums (for example user uploaded track manually)

Can you provide a case? When I tested the library, I could not get any local track in response.

@BrokenFG

…andexMusicSourceManager.java

Co-authored-by: AgutinVBoy <68972811+AgutinVBoy@users.noreply.github.com>
@BrokenFG
Copy link
Contributor Author

Can you provide a case? When I tested the library, I could not get any local track in response.

track must be uploaded to the account whose token is being used, idk what can i provide except of returning json result
https://pastebin.com/c15QWcy3

Repository owner deleted a comment from BrokenFG Nov 17, 2022
@topi314 topi314 merged commit b8660f7 into topi314:master Nov 17, 2022
@topi314 topi314 added the bugfix Something is hopefully working now label Nov 17, 2022
@topi314
Copy link
Owner

topi314 commented Nov 17, 2022

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something is hopefully working now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants