-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some fixes for yandex music which led to an error when loading a track or playlist #31
Conversation
Fix error when track is not available Fix error when track doesn't include in any albums (for example user uploaded track manually)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
else looks good. I assume you tested this as i can't
main/src/main/java/com/github/topisenpai/lavasrc/yandexmusic/YandexMusicSourceManager.java
Outdated
Show resolved
Hide resolved
@AgutinVBoy please also have a look |
can we not stream it in this case? |
Fix error when track is not available Fix error when track doesn't include in any albums (for example user uploaded track manually)
We won't, we check the track for availability and for its presence in the album, if any of these conditions are not met, we skip this track |
I came across these errors when trying to play my playlist, after these changes everything works fine for me |
Can you provide a case? When I tested the library, I could not get any local track in response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good from me. will wait for @AgutinVBoy before merging
Good fix. I have no complaints (only one review and one question)
|
main/src/main/java/com/github/topisenpai/lavasrc/yandexmusic/YandexMusicSourceManager.java
Outdated
Show resolved
Hide resolved
…andexMusicSourceManager.java Co-authored-by: AgutinVBoy <68972811+AgutinVBoy@users.noreply.github.com>
track must be uploaded to the account whose token is being used, idk what can i provide except of returning json result |
thx |
Fix error when track doesn't have cover
Fix error when track is not available
Fix error when track doesn't include in any albums (for example user uploaded track manually)