-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amol/flatten nested filters #956
Open
amol21p
wants to merge
33
commits into
toptal:master
Choose a base branch
from
apolloio:amol/flatten_nested_filters
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent three queries
fix searchable proc passing
Delete non indexable documents
Fix deprecated ruby 2.7 syntax
reproducing fix for i18n core ext
amol21p
force-pushed
the
amol/flatten_nested_filters
branch
2 times, most recently
from
June 28, 2024 12:27
1727ec7
to
857ff62
Compare
mightymercado
approved these changes
Jun 28, 2024
amol21p
force-pushed
the
amol/flatten_nested_filters
branch
from
June 28, 2024 13:18
857ff62
to
209de33
Compare
@amol21p thanks for you PR, could you please update Readme, with description what this PR is for and which features are introduced. thanks! |
@amol21p also please rebase your branch with the latest master. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this text with a summary of the changes in your PR.
The more detailed you are, the better.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).