Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doubts / Errors #1

Open
viriatusX opened this issue May 5, 2023 · 13 comments
Open

Doubts / Errors #1

viriatusX opened this issue May 5, 2023 · 13 comments

Comments

@viriatusX
Copy link

viriatusX commented May 5, 2023

Hi,

I have followed your guide but it does not work with custom domain, only in localhost. And it doesn't always work.. I am using the latest version of Ghost and Casper.

Also, if the Casper layout is in "stacked" it looks bad the login user / register (look the first image).

Captura de pantalla 2023-05-05 a las 20 07 34

Also I found one issue: in the "ghost-plugin.js" I change the port 3001 for the 3000:

const NOTIFICATION_URL = 'http://localhost:3001/api/subscribe/notification';

for

const NOTIFICATION_URL = 'http://localhost:3000/api/subscribe/notification';

and the service works correctly only in localhost on my Mac (Not on my NAS). It's strange.

How can I make it work with a domain? Not only with Ghost with LOCALHOST.
When I try to run with Ghost in custom domain (for ex. myblog.com) not work also.

The logs shows: (and

Captura de pantalla 2023-05-06 a las 1 06 37

Thanks for your work.
Can you look it please?

@viriatusX viriatusX changed the title Not work Doubts / Errors May 5, 2023
@viriatusX
Copy link
Author

It seems that this project has been abandoned. A pity.

@tq-bit
Copy link
Owner

tq-bit commented May 23, 2023

Hi Viri. I did a lot of coding locally without pushing. Feel free to check out the dev branch I just pushed, there's a lot of new logic and a UI 😄 I'll check out the point about the Domain as well, it's possible the new functionalities already cover this point.

If you need more info, I'll quickly try and put together a few visualizations and docs this weekend.

Thank you for your interest

@viriatusX
Copy link
Author

viriatusX commented May 23, 2023

Hi Viri. I did a lot of coding locally without pushing. Feel free to check out the dev branch I just pushed, there's a lot of new logic and a UI 😄 I'll check out the point about the Domain as well, it's possible the new functionalities already cover this point.

If you need more info, I'll quickly try and put together a few visualizations and docs this weekend.

Thank you for your interest

Thanks for your work @tq-bit !
The new script shows "(!) Unresolved dependencies" and "body-parser deprecated undefined extended: provide extended option at src/server/index.ts:" error I think.

Also, How can I allow login to the new UI or allow registration? I can't login to check if it works.

Captura de pantalla 2023-05-23 a las 10 19 10

On the other way. I have tried updating an article. This shows the log. But the little bell on the blog not shows nothing.

Captura de pantalla 2023-05-23 a las 10 31 33

See the video please: https://www.youtube.com/watch?v=6afZyr1jdkE

We are in contact,
Thank you very much

@viriatusX
Copy link
Author

viriatusX commented May 23, 2023

Another UPDATE:

I am not a still man. I'm doing my research :P
While you publish the documentation these days.... I figured out how to create the user, but it gives error. i made this video:

https://www.youtube.com/watch?v=xmcy9lkerPU

tq-bit added a commit that referenced this issue May 24, 2023
tq-bit added a commit that referenced this issue May 24, 2023
@tq-bit
Copy link
Owner

tq-bit commented May 24, 2023

Good thing, patience isn't a virtue :P

I've done a few changes.

  • I added a local mongodb image to use. It starts up with docker compose
  • As you pointed out in the vid, I've resetted the wasSuperUserCreated config
  • I've extended the env.example file, it was missing a property named 'JWT_KEY'. That's probably why you received the error

After taking a closer look at the codebase, I'm fairly sure the project needs an overhaul. I've focussed too much on doing client and server at once while I should've focussed on the latter. Fairly sure I won't get the time before late August though.

@viriatusX
Copy link
Author

viriatusX commented May 24, 2023

Good thing, patience isn't a virtue :P

I've done a few changes.

  • I added a local mongodb image to use. It starts up with docker compose
  • As you pointed out in the vid, I've resetted the wasSuperUserCreated config
  • I've extended the env.example file, it was missing a property named 'JWT_KEY'. That's probably why you received the error

After taking a closer look at the codebase, I'm fairly sure the project needs an overhaul. I've focussed too much on doing client and server at once while I should've focussed on the latter. Fairly sure I won't get the time before late August though.

Thanks for your quickly response!
IT'S WORK!!!!!!!!! :)

Only two littles thing....
See the 2 videos please: https://www.youtube.com/watch?v=sWfgg10hjiE&feature=youtu.be and https://www.youtube.com/watch?v=Z_X2PEpzVLc&feature=youtu.be

  1. If I edit the post, the notification shows "Post Published" instead of "Post Updated".
  2. And If I click on Read it now, the URL is always broken showing "Undefined".

Can this be fixed in a "quick" way?

And the last question please: Would it be possible for the notification on the little bell to remain until the user clicks on it? Currently if you do F5, the notification is lost.

Captura de pantalla 2023-05-24 a las 11 42 29

Thank you very much

@tq-bit
Copy link
Owner

tq-bit commented Jun 13, 2023

Hey Viri,

I'm happy to see it works :)
I'll have a look at your three points this weekend.

I've also started working on a newer and production-ready version of ghost-notifier with a lot of optimizations.
If you think it brings you the additional value, I'd really appreciate if you gave it a try once I have a stable alpha release.

Cheers, and thanks again for your feedback, I really appreciate it.

@viriatusX
Copy link
Author

Hi!
Thank you very much.
If that gets fixed this weekend let me know and I'll try it :)

Of course, I'll be willing to help to test the Alpha version of the new veraion too! :)

@tq-bit
Copy link
Owner

tq-bit commented Jun 18, 2023

Hi Viri,

I've pushed the latest two changes.

Both were related to improper naming in the Frontend JS Library, please have look if you like:

  1. Improper Notification type in UI:

1845684

  1. Broken URL:

c589b4f

The last point you mention is not so easy to implement. I could show the small red button, but cannot distinguish which of your readers has already read what message. For that, I would need to know which device that is currently reading your blog post has already toggled the button. And I currently have no way of doing that.

It's an interesting problem to think about though, I'll see if I can include it into my newer serverside app. Perhaps with a dedicated, anonymous cookie that's generated whenever a new client connects.

@viriatusX
Copy link
Author

viriatusX commented Jun 18, 2023

Hi!
now it's work perfectly! :)

"anonymous cookie that's generated whenever a new client connects." this sounds good!

Another thing. Since the latests versions of Casper Theme, they includes new Navigation layout "Stacked", but your bell not show correctly with this. "Moves" the member login/register to the center:

Thanks for all!

@viriatusX
Copy link
Author

Hi!
Any updates?
Thanks!

@tq-bit
Copy link
Owner

tq-bit commented Feb 21, 2024

Hi Viriatus

I've started a new project with the base functionality implemented.
It's far from finished, but I'll keep you in the loop once I feel confident enough to call it stable :)

Thanks for sticking with me here

@viriatusX
Copy link
Author

Excellent👏. I look forward to hearing more news 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants