INT-B-19226 onboarding required fields fix for boat shipments #13567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 26, 2024 13:46
…removed from text field.
…26-onboarding-required-fields
brooklyn-welsh
added
ByteSize M&Ms
brooklyn-welsh
requested review from
taeJungCaci,
KonstanceH and
WeatherfordAaron
KonstanceH
reviewed
Aug 26, 2024
WeatherfordAaron
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Everything looks good to me.. however, I was under the impression that the "Required" that is grey color would change to red and not that a red "Required" would appear.
I only bring this up in case you think there could potentially be issues during POA regarding that... if nobody else has brought this up, I wouldn't worry about it because that could add unnecessary time to completion of this one.
LGTM 👽
…26-onboarding-required-fields
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agility ticket
Other INT PR
#13548
Summary
Fixes the "dimensions" fields for boat shipments. Originally required text was duplicated because the boat shipment form doesn't follow the same HTML markup as other forms in the app. Now the required field should only show once under the tag for each dimension.
How to test
Same as previous INT PR, just be sure to check boat shipment when you are creating a shipment.