Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT-B-19226 onboarding required fields fix for boat shipments #13567

Merged

Conversation

brooklyn-welsh
Copy link
Contributor

Agility ticket

Other INT PR

#13548

Summary

Fixes the "dimensions" fields for boat shipments. Originally required text was duplicated because the boat shipment form doesn't follow the same HTML markup as other forms in the app. Now the required field should only show once under the tag for each dimension.

How to test

Same as previous INT PR, just be sure to check boat shipment when you are creating a shipment.

@brooklyn-welsh brooklyn-welsh added ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing labels Aug 26, 2024
@brooklyn-welsh brooklyn-welsh requested a review from a team as a code owner August 26, 2024 17:59
@robot-mymove
Copy link

robot-mymove commented Aug 26, 2024

Warnings
⚠️ This PR does not include changes to unit tests, even though it affects app code.

Generated by 🚫 dangerJS against 4f09407

Copy link
Contributor

@taeJungCaci taeJungCaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@KonstanceH KonstanceH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see all of the required text added and that looks good, but I still see "Optional" on the Remarks part.

Copy link
Contributor

@WeatherfordAaron WeatherfordAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me.. however, I was under the impression that the "Required" that is grey color would change to red and not that a red "Required" would appear.

I only bring this up in case you think there could potentially be issues during POA regarding that... if nobody else has brought this up, I wouldn't worry about it because that could add unnecessary time to completion of this one.

LGTM 👽

Screenshot 2024-08-27 at 8 15 28 AM

@brooklyn-welsh brooklyn-welsh merged commit 703e5d6 into integrationTesting Aug 28, 2024
29 of 30 checks passed
@brooklyn-welsh brooklyn-welsh deleted the INT-B-19226-onboarding-required-fields branch August 28, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

5 participants