MAIN B-19226 Onboarding required fields #13756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 14, 2024 17:03
…r side of the app now show red "required" warnings for every empty field as soon as the page is loaded.
…ed, required fields marked with grey text, flashes to red if user exits without entering data.
…xt removed, required fields marked with grey text, flashes to red if user exits without entering data." This reverts commit e949c3a.
…int where needed on customer side
…e new "Required" hint elements that are now present on onboarding forms.
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
…er-Flows-MAIN' into MAIN-B-19226-redo
…into MAIN-B-19226-redo
14 tasks
KonstanceH
approved these changes
Oct 9, 2024
brooklyn-welsh
requested review from
JamesHawks224,
WeatherfordAaron and
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agility ticket
Relevant INT PRs
#13474
#13548
#13567
#13609
Rebase INT PR: #13791
Summary
This PR changes customer onboarding and move creation forms in MilMove to label required fields with light grey "Required" text, while getting rid of the existing "Optional" text that currently accompanies optional fields. #13609 has the most up to date comparison for this PR, some changes in other INT PR's were reverted because they changed behavior in other parts of the app as well that we didn't want.
How to test
Please follow the steps listed in #13474 and #13548.