-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAIN B-19226 Onboarding required fields #13756
Conversation
…r side of the app now show red "required" warnings for every empty field as soon as the page is loaded.
…ed, required fields marked with grey text, flashes to red if user exits without entering data.
…xt removed, required fields marked with grey text, flashes to red if user exits without entering data." This reverts commit e949c3a.
…int where needed on customer side
…e new "Required" hint elements that are now present on onboarding forms.
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
…er-Flows-MAIN' into MAIN-B-19226-redo
…into MAIN-B-19226-redo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the late review. Once this branch is updated and any conflicts are fixed I think this is good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👽
Agility ticket
Relevant INT PRs
#13474
#13548
#13567
#13609
Rebase INT PR: #13791
Summary
This PR changes customer onboarding and move creation forms in MilMove to label required fields with light grey "Required" text, while getting rid of the existing "Optional" text that currently accompanies optional fields. #13609 has the most up to date comparison for this PR, some changes in other INT PR's were reverted because they changed behavior in other parts of the app as well that we didn't want.
How to test
Please follow the steps listed in #13474 and #13548.