Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-20940
Note
This is a follow up PR to #13574 , created in order to resolve some unexpected behavior from the originally supplied calculation
Summary
During PO Acceptance, our PO had to change a couple requirements about the calculation.
Originally it was planned that Member Disbursement should not be less than 0, however in the case that a member has requested an advance greater than their expenses, this value should be shown as negative to reflect the difference that they owe back to the government.
For this solution, it’s important to note that GTCC disbursement will only ever be less than 0 using the calculation of (remaining entitlement + member paid storage). In this case, member disbursement will be set to the value of the negative GTCC disbursement. GTCC disbursement will be set to 0. The other calculation of (GTCC Totaled other expenses + GTCC Storage expense) can never be less than 0.
In all other cases, the calculation will perform as outlined in the AC. This results in the disbursement numbers we are looking for.
This change has been described to the PO, and they agree that it's the best way forward.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
How to test
Backend