-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B 20940 disbursement #13696
B 20940 disbursement #13696
Conversation
Merge in to avoid conflicts
Latest main merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing a change to pkg/models/worksheet_shipment.go in the first integration PR, but I don't see that file as existing in main yet. When would this change go into main, if not this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Talked with Anthony via slack and got clarification - pkg/models/worksheet_shipment.go was created as part of @TevinAdams work on B-20947 so we will just want to make sure that change from unit.Pound to float64 makes it into Tevin's main PR https://github.com/transcom/mymove/pull/13594/files#diff-0062207dd5e2a86a57f6555b5ff0a71c6f26c09efc6dcd760061c54a738a70c5 |
B-20940
INT PR 1
INT PR 2
Summary
B-20940 introduces a disbursement calculation for the SSW, only when a Payment Packet is being created. Please consult the agility backlog item description for the overview of the calculation. Additionally, it is accompanied by a test that checks both methods of calculation, as well as ensuring the Member value cannot be less than 0. This also cleans up an incorrectly named orders value.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
How to test
Then, add another expense type of Storage, with a larger cost, NOT paid with GTCC.
This triggers our "A" calculation, making GTCC the amount of your oil expense, and allows us to verify member disbursement cannot be less than 0.
Then, add more expensive GTCC expenses. Member disbursement will still be 0 as in the calculation, the member paid storage will cancel out.
However, this triggers our "B" calculation where the GTCC value will be the amount of the member storage expense.
Backend
Screenshots