-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INT B-21022 - Include/Exclude specific offices #13730
INT B-21022 - Include/Exclude specific offices #13730
Conversation
…e to align with Danny M's spreadsheet. Update GHC handler to pass in forPpm parameter to ensure filteriing on ppm_closeout col.
pkg/handlers/routing/routing_init.go
Outdated
@@ -602,30 +602,6 @@ func mountPrimeSimulatorAPI(appCtx appcontext.AppContext, routingConfig *Config, | |||
rAuth.Mount("/", api.Serve(tracingMiddleware)) | |||
}) | |||
}) | |||
site.Route("/pptas/v1", func(r chi.Router) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was reverted in MAIN and not updated in INT -- 0733bb1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…elated to making forPPM param to true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified the ones in the list that are true are the only ones that are displayed in the closeout office list.
B-21022
Summary
INTEGRATION
This PR addresses issue of certain offices showing and not showing in the close out widget for both customer and office apps when onboarding/editing PPMs. An analysis was done to compare records in the transportation_offices table vs Excel/csv File:
Transportation Offices with Statuses 5 Sep 2024 -Validations.csv with respect to the provides_ppm_closeout field/column. Per Danny M, the Excel/csv file serves as the Gold standard.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
A migration file was created to update 7 records in the transporation_offices table, updating the provides_ppm_closeout column to match the Excel/csv file. They are the following:
PPPO Fort Belvoir - USA => change FALSE to TRUE
Personal Property Activity HQ (PPA HQ) - USAF => change TRUE to FALSE
PPPO Base Miami - USCG => change FALSE to TRUE
JPPSO - North West (JEAT) - USA => change TRUE to FALSE
PPPO NSWC Panama City Division - USN => change FALSE to TRUE
JPPSO - Mid Atlantic (BGAC) - USA => change TRUE to FALSE
JPPSO - South West (LKNQ) - USN => change TRUE to FALSE
TRUE => Visible in Closeout widget search results (selectable)
FALSE => Not shown/hidden in Closeout widget search results (not selectable)
Frontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes: