MAIN - B-21022 - Include/Exclude specific offices

[MInthavongsay]

B-21022

INT PR

Summary

MAIN

This PR addresses issue of certain offices showing and not showing in the close out widget for both customer and office apps when onboarding/editing PPMs. An analysis was done to compare records in the transportation_offices table vs Excel/csv File:
Transportation Offices with Statuses 5 Sep 2024 -Validations.csv with respect to the provides_ppm_closeout field/column. Per Danny M, the Excel/csv file serves as the Gold standard.

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

A migration file was created to update 7 records in the transporation_offices table, updating the provides_ppm_closeout column to match the Excel/csv file. They are the following:

PPPO Fort Belvoir - USA => change FALSE to TRUE
Personal Property Activity HQ (PPA HQ) - USAF => change TRUE to FALSE
PPPO Base Miami - USCG => change FALSE to TRUE
JPPSO - North West (JEAT) - USA => change TRUE to FALSE
PPPO NSWC Panama City Division - USN => change FALSE to TRUE
JPPSO - Mid Atlantic (BGAC) - USA => change TRUE to FALSE
JPPSO - South West (LKNQ) - USN => change TRUE to FALSE

TRUE => Visible in Closeout widget search results (selectable)
FALSE => Not shown/hidden in Closeout widget search results (not selectable)

1. Login as customer and create and submit a move containing a PPM.
2. Specifically verify the 7 offices are visible or hidden based on boolean state(provides_ppm_closeout) for the closeout widget. If you want you can do spot checks using anyone one of the offices in the attached Excel file according to the PPM Closeout column.
3. Login as service counselor and view submitted move PPM. Again verify the 7 offices are either visible or hidden on edit.
4. Add a new PPM from SC. Do the same verification and spot checks using Excel file as guide.
5. Are there any other places missed and not specified in the instructions? If so, check that too.

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

[r-mettler]

changes same as INT

[antgmann]

Matches!