fix digit escape in highlight regex for constants #112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: (:heavy_check_mark:)
This is the same idea as tree-sitter/tree-sitter-java#90, the
\d
should be\\d
to become the digit escape.This one is a bit more straightforward: the query currently misconstrues constants with digits in them as constructors (because of the rule below it).
pi.php
query1.scm
((name) @constant (#match? @constant "^_?[A-Z][A-Z\d_]+$"))
query2.scm
((name) @constant (#match? @constant "^_?[A-Z][A-Z\\d_]+$"))
reproduction