Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix land polygons download/extraction handling. #35

Merged

Conversation

mweirauch
Copy link
Contributor

Downloaded to common_resources but the constant which checks file existence
already points to common_download.

Theres also some formatting/linting changes automagically done by the VSCode Python extension. If you'd like these being taken out, let me know.

PS: No Python programmer at all.

Copy link
Owner

@treee111 treee111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for submitting the PR and the correction!
Functionality wise it works for me in both Windows and macOS.

The formatting think is ok for me. Which extention do you use and are there and additional settings?

One think I'd like you to add:
Could you please add you PR to the CHANGELOG file after PR33 because it is a correction of #33.
If you like with @mweirauch in the end to make your contribution visible!

common_python/downloader.py Outdated Show resolved Hide resolved
common_python/downloader.py Outdated Show resolved Hide resolved
@treee111 treee111 added the bug Something isn't working label Oct 11, 2021
Downloaded to common_resources but the constant which checks file existance
already points to common_download.
@mweirauch mweirauch force-pushed the fix-land-polygons-download-handling branch from fbc6183 to 05a2b3c Compare October 11, 2021 20:40
@mweirauch
Copy link
Contributor Author

I added it to the CHANGELOG, squashed the commits into one and force pushed. (Btw, nobody is handcrafting CHANGELOGs these days ... I usually use github-changelog-generator)

Regarind your question on the VSCode extension: It's the official Microsoft "Python" extension.

treee111
treee111 previously approved these changes Oct 11, 2021
Copy link
Owner

@treee111 treee111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! 👍

I have seen some of these plugins but never really digged into it...

@treee111
Copy link
Owner

Regarind your question on the VSCode extension: It's the official Microsoft "Python" extension.

I also have this standard extension but it didn't made formatting changes automatically for me. I'll check out how to activate that

Ebe66
Ebe66 previously approved these changes Oct 11, 2021
Copy link
Contributor

@Ebe66 Ebe66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well,it's working. one extremely little thingy though... You use land_poligons everywhere (in the changed file) can we change that to land_polygons please 😊

@mweirauch mweirauch dismissed stale reviews from Ebe66 and treee111 via d9f9ee3 October 11, 2021 22:04
@mweirauch
Copy link
Contributor Author

@Ebe66 oh hehe. Didn't even notice it was spelled "poligon" everywhere else. Pushed a second commit with the typo correction.

Copy link
Owner

@treee111 treee111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers again!

Copy link
Contributor

@Ebe66 Ebe66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure did a test run first and then forgot to do the approve of course. For me it's good to go...

@treee111 treee111 merged commit 9dafa07 into treee111:develop Oct 12, 2021
@mweirauch mweirauch deleted the fix-land-polygons-download-handling branch October 12, 2021 20:32
@treee111 treee111 changed the title Fix land polygons download/extraction handling. [FIX] Fix land polygons download/extraction handling. Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants