-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Fix land polygons download/extraction handling. #35
[FIX] Fix land polygons download/extraction handling. #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for submitting the PR and the correction!
Functionality wise it works for me in both Windows and macOS.
The formatting think is ok for me. Which extention do you use and are there and additional settings?
One think I'd like you to add:
Could you please add you PR to the CHANGELOG file after PR33 because it is a correction of #33.
If you like with @mweirauch in the end to make your contribution visible!
Downloaded to common_resources but the constant which checks file existance already points to common_download.
fbc6183
to
05a2b3c
Compare
I added it to the CHANGELOG, squashed the commits into one and force pushed. (Btw, nobody is handcrafting CHANGELOGs these days ... I usually use github-changelog-generator) Regarind your question on the VSCode extension: It's the official Microsoft "Python" extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! 👍
I have seen some of these plugins but never really digged into it...
I also have this standard extension but it didn't made formatting changes automatically for me. I'll check out how to activate that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well,it's working. one extremely little thingy though... You use land_poligons everywhere (in the changed file) can we change that to land_polygons please 😊
@Ebe66 oh hehe. Didn't even notice it was spelled "poligon" everywhere else. Pushed a second commit with the typo correction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cheers again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be sure did a test run first and then forgot to do the approve of course. For me it's good to go...
Downloaded to common_resources but the constant which checks file existence
already points to common_download.
Theres also some formatting/linting changes automagically done by the VSCode Python extension. If you'd like these being taken out, let me know.
PS: No Python programmer at all.