Fix typehint of JobBuriedEvent to accept \Throwable #20
Conversation
| @@ -884,6 +884,29 @@ public function testFatalErrorCatch() | |||
|
|
|||
| $this->assertEquals(false, $this->manager->executeJob($job)); | |||
| } | |||
|
|
|||
| public function testFatalErrorCatchWithNoRetries() | |||
There was a problem hiding this comment.
I'm not sure what this test adds in comparison to the previous test. I can see the difference but what fix does this test, and is it part of this PR?
There was a problem hiding this comment.
Thank you for your feeback - yes the difference between those two tests is subtle.
My test sets the releases attribute to 2 so the JobBuriedEvent is created. The previous test only reschedules the job and does not create the JobBuriedEvent. Maybe I can add an assertion that the JobBuriedEvent is dispatched to make this more explicit.
There was a problem hiding this comment.
I have now updated the testcase to check if the buried event has actually been dispatched. I hope the intent of the test is now clearer @pkruithof
Otherwise this will result in an unrelated TypeError exception.
vstm
force-pushed
the
fix/job-buried-event-typehint
branch
from
dffd694
to
f89629f
Compare
|
Thank you @vstm! |
Otherwise this will result in an unrelated
TypeErrorexception when an exception is thrown that is not inherited from\Exception.This is related to PR #16