Auto-release all clients when publishing with Maven #8378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielshaqed
added
pr/merge-if-approved
|
Nice! |
Isan-Rivkin
requested changes
Nov 17, 2024
pkg/config/config.go
Outdated
| @@ -388,6 +388,11 @@ type Config struct { | |||
| Enabled bool `mapstructure:"enabled"` | |||
| FlushInterval time.Duration `mapstructure:"flush_interval"` | |||
| } `mapstructure:"usage_report"` | |||
| Plugins map[string]struct { | |||
There was a problem hiding this comment.
Sorry @Isan-Rivkin , PTAL...
This property is covered in [the docs](https://central.sonatype.org/publish/publish-maven/#nexus-staging-maven-plugin-for-deployment-and-release). It also allows for a manual review opportunity... but given that we don't do that, and that we test first, let's not go there.
arielshaqed
force-pushed
the
chore/auto-release-all-clients-from-mvn
branch
from
8e00fbb to
ce834ec
Compare
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
Isan-Rivkin
approved these changes
Nov 17, 2024
|
Also worth noting the beautiful XML inheritance model for pom.xml. This affects all 3 Java clients. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look what I found! This property is covered in the
docs. It also allows for a manual review opportunity... but given that we don't do that, and that we test first, let's not go there.
Fixes #7974.
Tested by manually triggering a release on this branch. It finished and I see no staging repository on https://s01.oss.sonatype.org/#stagingRepositories. Naturally we will need to wait to see whether a release
test-auto-releaseactually made it to Maven central.But it's worth pulling even now, in the worst case we still need to do something extra.