Fix SAP profile comments parsing #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
changed the title
fabriziosestito
requested review from
dottorblaster,
arbulu89,
nelsonkopliku,
rtorrero and
CDimonaco
fabriziosestito
force-pushed
the
fix_sap_profile_comments_parsing
branch
from
70820f6 to
7edbc98
Compare
nelsonkopliku
approved these changes
Oct 20, 2022
arbulu89
approved these changes
Oct 20, 2022
tracking this |
CDimonaco
reviewed
Oct 20, 2022
CDimonaco
requested changes
Oct 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes profile file parsing that was adding commented-out line to the result config map.
Refactor the profile file parsing by using go-envparse instead of regex. No need to use
map[string]interface{}anymore as the parsed values are strings.