Use go-envparse in sbd gatherer #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonkopliku
force-pushed
the
refactor_sbd_gatherer
branch
from
04cb5ed to
042da02
Compare
nelsonkopliku
force-pushed
the
refactor_sbd_gatherer
branch
from
042da02 to
cc5b0e5
Compare
nelsonkopliku
requested review from
arbulu89,
CDimonaco,
dottorblaster and
fabriziosestito
arbulu89
reviewed
Oct 31, 2022
It's not there anymore, I guess it has been removed in some previous PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up #122 by using go-envparse to parse sbd configuration.
Note: I couldn't really run tests locally 😅 some issues with the temporary
_todopackaging.I temporarily moved the files among the real gatherers and tested that way (passed), then moved back in
_todoLow prio, we'll get back to gatherers at a certain point 😄