-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiversion package support #181
Conversation
487a335
to
02f4f4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nelsonkopliku ,
Good job!
I find the some of the code ultra defensive, for scenarios that I don't know even know can really happen, but no harm I guess. The installedVersions[0].Version
is the one that could worry me, but maybe it cannot even happen to not have any value there
PD: I would never imagine of doing this with env parsing hehe
But good call
02f4f4b
to
3a46886
Compare
3a46886
to
a7cbeff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nelsonkopliku
This PR follows up discussion trento-project/wanda#150 and adds support for multiversion package detection.
Gatherer now returns a list representing the installed versions for the specific package
Only one version installed detected
Many versions installed detected for the package (
sbd
in the example)As agreed, versions are ordered by installation time desc - latest installed first.
With this we should be able to unlock trento-project/wanda#124 and relevant premium checks.
Doc update here trento-project/wanda#182