rewrite trento community checks regarding 'package version' #124
Conversation
…-1130, jsc#CFSA-1131, jsc#CFSA-1109, jsc#CFSA-1108, jsc#CFSA-1134, jsc#CFSA-1067, jsc#CFSA-1125, jsc#CFSA-1137)
| facts: | ||
| - name: os_flavor | ||
| gatherer: package_version | ||
| argument: SLES_SAP-release |
There was a problem hiding this comment.
This usage of the package_version gatherer would result in the following command
$ rpm -q --qf "%{VERSION}" SLES_SAP-releaseIs this the way to determine that the OS is SLES4SAP? Asking because I might very well ignore it 😅
I tried it on a SLES 15 sp3 of ours - not a 4SAP though - and it returns package SLES_SAP-release is not installed
If the package_version gatherer is not suitable to determine the OS, we might need a different gatherer.
There was a problem hiding this comment.
yes, your right. It is a workaround, but a reliable working 'workaround'. The package 'SLES_SAP-release' is only available on SLES for SAP systems. On a plain SLES you will have the 'SLES-release' package.
The recommended way (as we told our partners) is to evaluate /etc/products.d/baseproduct and search for '<name>', '<cpeid>' or '<productline>' depending on the use case.
There was a problem hiding this comment.
@angelabriel We can merge as it is by now, and open a new ticket to maybe implement a new gatherer to get the version. What do you think?
There was a problem hiding this comment.
@arbulu89 Sounds good. Having a gatherer for the os version (based on /etc/os-release or /etc/products.d/baseproduct ) and the os flavor (based on /etc/products.d/baseproduct ) would be really nice.
But it's not urgent as by now we can live with the workarounds.
Thanks
| facts: | ||
| - name: os_flavor | ||
| gatherer: package_version | ||
| argument: SLES_SAP-release |
There was a problem hiding this comment.
@angelabriel We can merge as it is by now, and open a new ticket to maybe implement a new gatherer to get the version. What do you think?
priv/catalog/D028B9.yaml
Outdated
| - https://documentation.suse.com/en-us/sbp/all/single-html/SLES4SAP-hana-sr-guide-PerfOpt-15/ | ||
|
|
||
| facts: | ||
| - name: SLES_SAP_version |
There was a problem hiding this comment.
I would stick to small case here for the name
…e characters in 'facts', 'expects' and 'expectations'
| facts: | ||
| - name: exclude_package_pacemaker | ||
| gatherer: package_version | ||
| argument: pacemaker,2.0.3+20200511.2b248d828 |
There was a problem hiding this comment.
This could very well done as before, just letting the version in the values, and comparing with the package version string, as we simply wanted a different value.
But both work
Done |
using gatherer 'package_version' to fix jsc#CFSA-1130, jsc#CFSA-1131, jsc#CFSA-1109, jsc#CFSA-1108, jsc#CFSA-1134, jsc#CFSA-1067, jsc#CFSA-1125, jsc#CFSA-1137