-
-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify touch and button handling, enable usage of both in one model #3083
Conversation
753b4e8
to
6e6473f
Compare
… in one model [no changelog]
6e6473f
to
1035c24
Compare
…of both in one model
9a0c1a3
to
b0b7817
Compare
why not keep the button and touch interfaces separate and just allow both to be available at the same time? in general we don't really want to keep the button code active in TT and vice-versa for TR. to facilitate that, we should do to |
not sure how to do that actually, could that be done with |
…of both in one model
added the replacement: 5925829 |
…of both in one model
|
…of both in one model
ok trying it that way here: 72b816a a bit annoying is needing to add the variants in several layout subclasses (for debug) But mainly i am realizing here that this PR does not yet handle debug both interfaces properly, will need some more work. I don't like how button debug signal is implemented too: the middle button synthesis in TR layout seems wrong there, shouldn't it be synthesized rather in concrete tests? although it would probably require of sending PRESS and RELEASE separately, or maybe allow sending arbitrary button sequence. I would say that in this layout class we shouldn't care much about concrete buttons and their names (LEFT, RIGHT, etc), just receive a button code and send it to rust for interpretation. Thinking how to make the layout compatible with future models, where we won't have a LEFT and RIGHT button, but for example POWER button. Also not sure what 'swipe' is for in TR/button based model, seems odd. |
What is the state of this one? |
it's in progress as part of #2299 |
closing in favor of #2335 |
We will need this in a future model. Only layout for TT is modifed to be able to serve both, with hope that we will unify the layout API soon.